Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http to https #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

http to https #147

wants to merge 1 commit into from

Conversation

julienchastang
Copy link
Member

No description provided.

Copy link
Member

@ethanrd ethanrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been reviewing Unidata XLM Namespace URIs given the changes necessitated by the webmod2 project.

I've suggested some changes to this PR based on that discussion (for both Unidata and other XML Namespace URIs).

@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<p:resource xmlns:p="http://datacite.org/schema/kernel-3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XML Namespace URIs are just unique strings that, by convention, usually happen to look like HTTP URLs.
They should not be changed to update "http:" to "https:".

@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<catalog xmlns="https://www.unidata.ucar.edu/namespaces/thredds/InvCatalog/v1.0" xmlns:xlink="http://www.w3.org/1999/xlink" name="Latest Unidata IDD Model Data" version="1.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Unidata XML Namespace URIs should be changed back to start with "http:".
The XLink namespace URI should not be changed.
Of course, I notice the motherlode:8080 URLs which are defunct. So ... ?

@@ -1,11 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<catalog name="LEAD TestBed IDV Data" version="0.6"
xmlns="http://www.unidata.ucar.edu/thredds"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This XML Namespace must be very old. We've used the www.unidata.ucar.edu/namespaces/* URIs for a very long time.

@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<catalog xmlns="https://www.unidata.ucar.edu/namespaces/thredds/InvCatalog/v1.0" xmlns:xlink="http://www.w3.org/1999/xlink" name="Latest Unidata IDD Model Data" version="1.0">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here again the Unidata Namespace URIs should be changed back to "http:" and the XLink ones should not be changed to "https:".

@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<catalog xmlns="https://www.unidata.ucar.edu/namespaces/thredds/InvCatalog/v1.0" xmlns:xlink="http://www.w3.org/1999/xlink" name="TREX Catalog">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And again, the Unidata and XLink URIs ...
I won't comment on any remaining ones. Probably all the "xmlns" attributes should be reviewed.

@@ -75,15 +75,15 @@

/** xml items */
public static final String XMLNS_XMLNS =
"http://a9.com/-/spec/opensearch/1.1/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting these which aren't in XML files ...

</service>
<!-- simple collection -->
<action name="Radar chooser" url="/ucar/unidata/idv/chooser/radarchooser.xml"/>
<action name="Catalog4" url="/ucar/unidata/idv/chooser/catalog4.xml"/>
<action name="Contained test" >
<datasetChoice name="NEXRAD Level 3 Radar"
actiontemplate="http://motherlode.ucar.edu/cgi-bin/thredds/RadarServer.pl?stn=FTG&amp;product=N0R&amp;time=1hour">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any motherlode.ucar.edu URLs are probably no longer available. I think motherlode redirects to atm.ucar.edu but I'm pretty sure there hasn't been any cgi-bin content in quite some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants