Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precise error msg on destination delete #1148

Merged
merged 3 commits into from
Jan 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/1147.fixed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Show relevant error message on destination delete by passing the original exception message to the UI.
4 changes: 2 additions & 2 deletions src/argus/htmx/destination/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ def delete_htmx(request, pk: int) -> HttpResponse:
try:
medium = api_safely_get_medium_object(destination.media.slug)
medium.raise_if_not_deletable(destination)
except NotificationMedium.NotDeletableError:
error_msg = "That destination cannot be deleted."
except NotificationMedium.NotDeletableError as e:
error_msg = " ".join(e.args)
else:
destination.delete()

Expand Down
Loading