-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use forms in destination page #1161
base: master
Are you sure you want to change the base?
Conversation
1087430
to
a51d4e7
Compare
.. also make it easioer to validate the settings-field with a django form.
a51d4e7
to
b1c02c5
Compare
b1c02c5
to
b4c8a33
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1161 +/- ##
==========================================
- Coverage 78.48% 77.45% -1.03%
==========================================
Files 141 141
Lines 5442 5553 +111
==========================================
+ Hits 4271 4301 +30
- Misses 1171 1252 +81 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues while testing this:
Trying to update a destination gives the error "This email destination already exists." This happens if you make no changes to the form and click "update", or only change either label or the setting. But if you change both to unique values that are not used in another destination, then it updates. It seems like the validation doesn't understand that the updated destination will replace the original, and just treats it like you're trying to create a new destination with the same label and or setting.
Simultaneously, a new collapse elements is created that is empty with the title (0)
Another problem (relevant comment here is when you try to create a new destination (or update) with a label or email that collides with an existing destination, you get the error message "This email destination already exists", but it does not indicate in any way if the problem is the label, the email or both
Depends on #936
Review file by file
Will be squashed