CLI: explorer rework and contract verification #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretzke
force-pushed
the
deploy-cli-explorer-rework
branch
from
339b70c to
4e0507a
Compare
gretzke
changed the title
|
no manual override yet, but now the detection of explorers works a lot better |
|
adds contract verification as feature #48 |
marktoda
reviewed
Feb 13, 2025
|
|
||
| fn main() { | ||
| // Create assets directory | ||
| let clean = env::var("CLEAN").unwrap_or("false".to_string()) == "true"; |
There was a problem hiding this comment.
recommend using structopt to manage env variables / cli parameters
marktoda
reviewed
Feb 13, 2025
| pub name: String, | ||
| pub url: String, | ||
| pub standard: String, | ||
| pub explorer_type: SupportedExplorerType, |
There was a problem hiding this comment.
Recommend having the enum be the top level type with struct variant, to allow for potential of different explorer types needing different parameters / behavior. like
enum ExplorerType {
Etherscan(ExplorerData),
Blockscout(ExplorerData),
...
NewExplorer(OtherExplorerData),
}
There was a problem hiding this comment.
oh that's cool, thanks!
marktoda
reviewed
Feb 13, 2025
| } | ||
|
|
||
| impl ExplorerApiLib { | ||
| pub fn new(explorer: Explorer, api_key: String) -> Result<Self, Box<dyn std::error::Error>> { | ||
| if explorer.name.to_lowercase().contains("blockscout") { | ||
| if explorer.explorer_type == SupportedExplorerType::Blockscout { |
There was a problem hiding this comment.
Recommend a match statement rather than if tree. better type checking for case coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44