Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

circular dependency between Currency, BaseCurrency and NativeCurrency #12

Open
justindomingue opened this issue Oct 7, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers p2 Low Priority

Comments

@justindomingue
Copy link
Contributor

Currency -> Native Currency -> Base Currency -> Currency

@marktoda marktoda added enhancement New feature or request good first issue Good for newcomers p2 Low Priority labels Jul 6, 2022
@marktoda
Copy link
Contributor

marktoda commented Jul 6, 2022

Hey @justindomingue - thanks for reporting this, nice catch! On quick glance, it seems an easy solution would be to have BaseCurrency remove its dependency on Currency by just updating equals(..) to be equals(other: BaseCurrency) instead of equals(other: Currency), I think. Feel free to submit a PR to address it!

@ef3n9r98
Copy link

Hey @marktoda,

Have you found a developer for this yet?

If not, I’ll add it to our site and then find a dev for you.

You wouldn’t have to fund a bounty until someone wants to fix it.

Your bounty is locked in a smart contract until you merge the dev’s PR. That releases it automatically.

Let me know if you have a budget and I’ll add it to our site.

@ashutosh887
Copy link

I would like to work on this @ef3n9r98 @justindomingue

hiroshitashir added a commit to hiroshitashir/sdk-core that referenced this issue Jun 27, 2023
…niswap#12

- Removed a cicular dependency by changing `equals(other: Currency)` to `equals(other: BaseCurrency)` per comment at Uniswap#12 (comment)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers p2 Low Priority
Projects
Development

No branches or pull requests

4 participants