Skip to content

Commit

Permalink
circular dependency between Currency, BaseCurrency and NativeCurrency U…
Browse files Browse the repository at this point in the history
…niswap#12

- Removed a cicular dependency by changing `equals(other: Currency)` to `equals(other: BaseCurrency)` per comment at Uniswap#12 (comment)
  • Loading branch information
hiroshitashir committed Jun 27, 2023
1 parent 18078db commit ea88dcd
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/entities/baseCurrency.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import invariant from 'tiny-invariant'
import { Currency } from './currency'
import { Token } from './token'

/**
Expand Down Expand Up @@ -53,7 +52,7 @@ export abstract class BaseCurrency {
* Returns whether this currency is functionally equivalent to the other currency
* @param other the other currency
*/
public abstract equals(other: Currency): boolean
public abstract equals(other: BaseCurrency): boolean

/**
* Return the wrapped version of this currency that can be used with the Uniswap contracts. Currencies must
Expand Down

0 comments on commit ea88dcd

Please sign in to comment.