Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-sdk): fix mixed route ETH <-> WETH wrong route.path #299

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Feb 5, 2025

PR Scope

Please title your PR according to the following types and scopes following conventional commits:

  • fix(SDK name): will trigger a patch version
  • chore(<type>): will not trigger any release and should be used for internal repo changes
  • <type>(public): will trigger a patch version for non-code changes (e.g. README changes)
  • feat(SDK name): will trigger a minor version
  • feat(breaking): will trigger a major version for a breaking change

Description

[Summary of the change, motivation, and context]

How Has This Been Tested?

[e.g. Manually, E2E tests, unit tests, Storybook]

Are there any breaking changes?

[e.g. Type definitions, API definitions]

If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.

(Optional) Feedback Focus

[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]

(Optional) Follow Ups

[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]

@jsy1218 jsy1218 marked this pull request as ready for review February 5, 2025 01:07
@jsy1218 jsy1218 requested review from a team as code owners February 5, 2025 01:07
Copy link
Member Author

jsy1218 commented Feb 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@snreynolds snreynolds force-pushed the siyujiang/router-sdk-fix-eth-weth-route.path branch from e4f37e6 to 953c044 Compare February 5, 2025 19:16
@jsy1218 jsy1218 force-pushed the siyujiang/router-sdk-fix-eth-weth-route.path branch from fe4e2fc to 881d2b2 Compare February 5, 2025 20:36
@graphite-app graphite-app bot requested a review from a team February 6, 2025 00:48
Copy link

graphite-app bot commented Feb 6, 2025

Graphite Automations

"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (02/06/25)

1 assignee was added and 2 reviewers were added to this PR based on Siyu Jiang (See-You John)'s automation.

@jsy1218 jsy1218 force-pushed the siyujiang/router-sdk-fix-eth-weth-route.path branch from 3b9f349 to 07f62c4 Compare February 6, 2025 19:17
@jsy1218 jsy1218 merged commit edf1c7b into main Feb 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants