-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable v2 routing on all deployed L2 #465
Conversation
Looks like the merge conflict needs to be resolved before Github CI runs the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we run some tests to make sure this works on optmism before we push it?
I think we want to conduct some manual testing (and maybe add into integ-test as well):
We are blocked on 1 right now. |
Also I just noticed that somehow for v2 pool-provider, SOR doesn't use FACTORY_ADDRESS from v2-sdk, but rather computes the pool address directly https://github.com/Uniswap/smart-order-router/blob/main/src/providers/v2/pool-provider.ts#L261. This was probably fine previously, because UR was not deployed for v2 pools. But now with UR with different factory addresses across chains, we might need to change the v2 pool-provider logic. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected], npm/@uniswap/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, assuming it works
I noticed v2-sdk FACTORY_ADDRESS_MAP is missing CELO. This explains why the CELO integ-tests are consistently failing. We will need to bump v2-sdk to include re-deployed CELO address. |
…e a seperate PR for op-sepolia
Sadly we aren't able to test on any deployed L2, including Optimism. The reason is because no has added liquidity on V2 deployed L2 yet. For example, the latest UniswapV2Router02 deployed Optimism shows no one ever invoked addLiquidity/addLiquidityETH of the write contract. I think we want to merge this first, meanwhile getting to how to add liquidity to test routing. |
enables v2 routes on all deployed L2
currenty SOR assumes v2 isn't deployed on all L2
support v2 routes on all deployed L2