fix: log error response in case of tenderly node non 200 http status #620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Besides small amount of tenderly API vs tenderly node response mismatch, I noticed small amount of TenderlyNodeGasEstimateBundleFailure.
This is due to:
If I hit against the same tenderly node endpoint with the same payload, I got a result array:
This tells me that
Cannot read properties of undefined (reading 'length')
from readingresp.result.length
is a sporadic runtime error, most likely because tenderly returned a non-200 status code.What is the new behavior (if this is a feature change)?
If tenderly node returns non-200, we want to log that response as error.
Other information: