Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log error response in case of tenderly node non 200 http status #620

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Jun 27, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Besides small amount of tenderly API vs tenderly node response mismatch, I noticed small amount of TenderlyNodeGasEstimateBundleFailure.

This is due to:

Screenshot 2024-06-27 at 3.17.16 PM.png

If I hit against the same tenderly node endpoint with the same payload, I got a result array:

{"id":1,"jsonrpc":"2.0","result":[{"error":{"code":3,"message":"execution reverted","data":"0x"}},{"gas":"0x77e6","gasUsed":"0x77e6"},{"gas":"0x29cee","gasUsed":"0x23bac"}]}%         

This tells me that Cannot read properties of undefined (reading 'length') from reading resp.result.length is a sporadic runtime error, most likely because tenderly returned a non-200 status code.

  • What is the new behavior (if this is a feature change)?
    If tenderly node returns non-200, we want to log that response as error.

  • Other information:

Copy link
Member Author

jsy1218 commented Jun 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 marked this pull request as ready for review June 27, 2024 22:19
@jsy1218 jsy1218 requested a review from a team as a code owner June 27, 2024 22:19
@graphite-app graphite-app bot requested review from mikeki, xrsv and cgkol June 27, 2024 22:19
Copy link

graphite-app bot commented Jun 27, 2024

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (06/27/24)

4 reviewers were added and 1 assignee was added to this PR based on 's automation.

Copy link
Member Author

jsy1218 commented Jun 27, 2024

Merge activity

  • Jun 27, 7:15 PM EDT: @jsy1218 started a stack merge that includes this pull request via Graphite.
  • Jun 27, 7:15 PM EDT: Graphite couldn't merge this PR because it failed optional checks and "ignore optional checks" was not selected.
  • Jun 27, 7:51 PM EDT: @jsy1218 started a stack merge that includes this pull request via Graphite.
  • Jun 27, 7:55 PM EDT: @jsy1218 merged this pull request with Graphite.

@jsy1218 jsy1218 merged commit c8218dd into main Jun 27, 2024
26 checks passed
@jsy1218 jsy1218 deleted the jsy1218/log-tenderly-node-error-response branch June 27, 2024 23:55
@jsy1218 jsy1218 mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants