-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump sor to 4.7.1 - fix: v4 subgraph provider add ETH base token, and custom fee tier and tick spacings #751
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (10/15/24)3 reviewers were added and 1 assignee was added to this PR based on 's automation. |
62035a0
to
0068562
Compare
for tomorrow's web v4 bash, i think this PR is critical to make people be able to swap v4 ETH/USDC pools on sepolia. But we just newly initialized new correct-sqrtPriceX96 ETH/USDC pools with hardcoded hook address 0x0000000000000000000000000000000000000020. right now SOR only searches v4 pool with hook address of On production nets, we shouldn't allow any hook routing yet though. |
I want to modify the sepolia alpha-router integ test to try native -> USDC with 0x0000000000000000000000000000000000000020 quote and tenderly simulated swap UPDATE - DONE, and working! |
…en, and custom fee tier and tick spacings (#872) release Uniswap/smart-order-router#751
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Right now v4 is hardcoded with v3 fee tiers and tickspacings. Also static subgraph provider is not able to get native ETH v4 pool.
What is the new behavior (if this is a feature change)?
allow routing-api to pass in more v4 custom fee tiers and tickspacings on a per-need basis. Also static subgraph should get ETH base token to get native v4 pool. Later is in case the v4 subgraph has too many bugs so that we cannot rely on live subgraph to filter by TVL.
Other information: