Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sor to 4.7.1 - fix: v4 subgraph provider add ETH base token, and custom fee tier and tick spacings #751

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Oct 15, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Right now v4 is hardcoded with v3 fee tiers and tickspacings. Also static subgraph provider is not able to get native ETH v4 pool.

  • What is the new behavior (if this is a feature change)?
    allow routing-api to pass in more v4 custom fee tiers and tickspacings on a per-need basis. Also static subgraph should get ETH base token to get native v4 pool. Later is in case the v4 subgraph has too many bugs so that we cannot rely on live subgraph to filter by TVL.

  • Other information:

Copy link
Member Author

jsy1218 commented Oct 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 marked this pull request as ready for review October 15, 2024 02:42
@jsy1218 jsy1218 requested a review from a team as a code owner October 15, 2024 02:42
@graphite-app graphite-app bot requested review from xrsv and cgkol October 15, 2024 02:42
Copy link

graphite-app bot commented Oct 15, 2024

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (10/15/24)

3 reviewers were added and 1 assignee was added to this PR based on 's automation.

@jsy1218 jsy1218 force-pushed the siyujiang/route-317-tech-debt-v4-static-subgraph-base-token-should-include branch from 62035a0 to 0068562 Compare October 15, 2024 21:09
@jsy1218
Copy link
Member Author

jsy1218 commented Oct 15, 2024

for tomorrow's web v4 bash, i think this PR is critical to make people be able to swap v4 ETH/USDC pools on sepolia. But we just newly initialized new correct-sqrtPriceX96 ETH/USDC pools with hardcoded hook address 0x0000000000000000000000000000000000000020. right now SOR only searches v4 pool with hook address of address(0). We will have to allow routing-api to pass in the hardcoded hook address on Sepolia in order to be able to swap ETH/USDC pools with hook address 0x0000000000000000000000000000000000000020 tmrw.

On production nets, we shouldn't allow any hook routing yet though.

cc @cgkol @xrsv

@jsy1218
Copy link
Member Author

jsy1218 commented Oct 15, 2024

I want to modify the sepolia alpha-router integ test to try native -> USDC with 0x0000000000000000000000000000000000000020 quote and tenderly simulated swap

UPDATE - DONE, and working!

@jsy1218 jsy1218 changed the title fix: v4 subgraph provider add ETH base token, and custom fee tier and tick spacings chore: bump sor to 4.7.1 - fix: v4 subgraph provider add ETH base token, and custom fee tier and tick spacings Oct 15, 2024
@jsy1218 jsy1218 merged commit f7d78d5 into main Oct 15, 2024
28 of 29 checks passed
@jsy1218 jsy1218 deleted the siyujiang/route-317-tech-debt-v4-static-subgraph-base-token-should-include branch October 15, 2024 22:50
jsy1218 added a commit to Uniswap/routing-api that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants