Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sor to 4.8.0 - feat: migrate base tenderly to new endpoint #762

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Nov 8, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    we don't support new tenderly endpoint on base yet.

  • What is the new behavior (if this is a feature change)?
    we will support new tenderly endpoint on base

  • Other information:

Copy link
Member Author

jsy1218 commented Nov 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 marked this pull request as ready for review November 8, 2024 00:57
@jsy1218 jsy1218 requested a review from a team as a code owner November 8, 2024 00:57
@graphite-app graphite-app bot requested a review from cgkol November 8, 2024 00:59
@graphite-app graphite-app bot requested a review from xrsv November 8, 2024 00:59
@jsy1218 jsy1218 changed the title feat: migrate base tenderly to new endpoint chore: bump sor to 4.8.0 - feat: migrate base tenderly to new endpoint Nov 8, 2024
Copy link

graphite-app bot commented Nov 8, 2024

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (11/08/24)

3 reviewers were added and 1 assignee was added to this PR based on 's automation.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem, network, shell Transitive: eval, unsafe +245 165 MB kanej

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Filesystem access npm/[email protected] ⚠︎
Filesystem access npm/[email protected] ⚠︎
Filesystem access npm/[email protected] ⚠︎
Dynamic require npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

What is dynamic require?

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Packages should avoid dynamic imports when possible. Audit the use of dynamic require to ensure it is not executing malicious or vulnerable code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@jsy1218 jsy1218 merged commit 4ec1b3b into main Nov 8, 2024
24 of 29 checks passed
@jsy1218 jsy1218 deleted the siyujiang/tenderly-base-new-endpoint branch November 8, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants