Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use syntheticGasCostInTermsOfQuoteToken only if within 30% of gasCostInTermsOfQuoteToken #776

Merged
merged 4 commits into from
Dec 4, 2024
Merged

fix: Use syntheticGasCostInTermsOfQuoteToken only if within 30% of gasCostInTermsOfQuoteToken #776

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1d030a
fix: Use syntheticGasCostInTermsOfQuoteToken only if within 30% of ga…
xrsv Dec 3, 2024
0e7ea93
asFraction
xrsv Dec 3, 2024
269b7d0
multiply percent
xrsv Dec 3, 2024
0e135c6
increase gas test deviation percent
xrsv Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/routers/alpha-router/gas-models/tick-based-heuristic-gas-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,16 @@ export abstract class TickBasedHeuristicGasModelFactory<
// Note that the syntheticGasCost being lessThan the original quoted value is not always strictly better
// e.g. the scenario where the amountToken/ETH pool is very illiquid as well and returns an extremely small number
// however, it is better to have the gasEstimation be almost 0 than almost infinity, as the user will still receive a quote
// Only use syntheticGasCostInTermsOfQuoteToken if it's within 30% of the original gasCostInTermsOfQuoteToken as a safeguard.
xrsv marked this conversation as resolved.
Show resolved Hide resolved
if (
syntheticGasCostInTermsOfQuoteToken !== null &&
(gasCostInTermsOfQuoteToken === null ||
(gasCostInTermsOfQuoteToken === null || (
syntheticGasCostInTermsOfQuoteToken.lessThan(
gasCostInTermsOfQuoteToken.asFraction
))
) &&
gasCostInTermsOfQuoteToken.subtract(syntheticGasCostInTermsOfQuoteToken)
.lessThan(gasCostInTermsOfQuoteToken.multiply(0.3).asFraction)
))
) {
log.info(
{
Expand Down
Loading