Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sor to 4.10.1 - fix: ID_TO_NETWORK_NAME add unichain and monad testnet #790

Merged

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Jan 8, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    routing-api release pipeline failed:

Error: Unknown chain id: 41454
at ID_TO_NETWORK_NAME (/codebuild/output/src1403594110/src/node_modules/@uniswap/smart-order-router/src/util/chains.ts:340:13)
at /codebuild/output/src1403594110/src/bin/stacks/routing-dashboard-stack.ts:113:78
at Array.map ()
at /codebuild/output/src1403594110/src/bin/stacks/routing-dashboard-stack.ts:108:27
at arrayMap (/codebuild/output/src1403594110/src/node_modules/lodash/lodash.js:653:23)
at map (/codebuild/output/src1403594110/src/node_modules/lodash/lodash.js:9622:14)
at Function.flatMap (/codebuild/output/src1403594110/src/node_modules/lodash/lodash.js:9325:26)
at new RoutingDashboardStack (/codebuild/output/src1403594110/src/bin/stacks/routing-dashboard-stack.ts:102:57)
at new RoutingAPIStack (/codebuild/output/src1403594110/src/bin/stacks/routing-api-stack.ts:245:5)
at Object. (/codebuild/output/src1403594110/src/bin/app.ts:420:1)

  • What is the new behavior (if this is a feature change)?
    we should add unichain and monad testnet into ID_TO_NETWORK_NAME

  • Other information:

Copy link
Member Author

jsy1218 commented Jan 8, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jsy1218 jsy1218 marked this pull request as ready for review January 8, 2025 17:39
@jsy1218 jsy1218 requested a review from a team as a code owner January 8, 2025 17:39
@graphite-app graphite-app bot requested review from xrsv and cgkol January 8, 2025 17:41
@jsy1218 jsy1218 merged commit 55521f5 into main Jan 8, 2025
19 of 29 checks passed
Copy link
Member Author

jsy1218 commented Jan 8, 2025

Merge activity

  • Jan 8, 12:42 PM EST: A user merged this pull request with Graphite.

@jsy1218 jsy1218 deleted the siyujiang/fix-id-to-network-name-unichain-monad-testnet branch January 8, 2025 17:42
Copy link

graphite-app bot commented Jan 8, 2025

Graphite Automations

"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (01/08/25)

3 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants