Add wrap, unwrap functionality #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Oct 17, 2024
src/base/NativeWrapper.sol
Outdated
| } | ||
|
|
||
| function wrap(uint256 _amount) external payable { | ||
| uint256 amount = _amount == ActionConstants.CONTRACT_BALANCE ? address(this).balance : _amount; |
There was a problem hiding this comment.
might be worth added 2 extra checks to each of these functions
- if
amount > balancerevert - so that theres a nice custom error? - only deposit (or withdraw) if
amount != 0. As someone might pass inCONTRACT_BALANCEand the current balance is 0 so then deposit/withdraw shouldnt be called
So maybe like
if (amount == ActionConstants.CONTRACT_BALANCE) {
amount = address(this).balance;
} else if (amount > address(this).balance) {
revert InsufficientETH();
}
if (amount > 0) WETH9.deposit{value: amount}();
hensha256
reviewed
Oct 18, 2024
hensha256
reviewed
Oct 18, 2024
hensha256
reviewed
Oct 18, 2024
hensha256
reviewed
Oct 18, 2024
| /// @notice Calculates the sanitized amount before wrapping/unwrapping. | ||
| /// @param inputCurrency The currency, either native or wrapped native, that the contract holds | ||
| /// @param amount The amount to wrap or unwrap. Can be CONTRACT_BALANCE or OPEN_DELTA or a specific amount | ||
| /// @param outputCurrency The currency after the wrap/unwrap that the user may owe a balance in on the poolManager |
There was a problem hiding this comment.
Suggested change
| /// @param outputCurrency The currency after the wrap/unwrap that the user may owe a balance in on the poolManager | |
| /// @param outputCurrency The currency after the wrap/unwrap |
There was a problem hiding this comment.
They also could be wrapping/unwrapping before sweeping to themselves etc. I feel like theres a few valid use-cases so shouldnt single one out
There was a problem hiding this comment.
yeah but outputCurrency is only used to get the OPEN_DELTA balance on the contract
There was a problem hiding this comment.
i didn't change this but lmk i can change if you still think so after reading this comment above^
| @@ -241,6 +241,13 @@ library CalldataDecoder { | |||
| } | |||
| } | |||
|
|
|||
| /// @dev equivalent to: abi.decode(params, (uint256)) in calldata | |||
| function decodeUint256(bytes calldata params) internal pure returns (uint256 amount) { | |||
| @@ -308,4 +329,114 @@ contract PositionManagerModifyLiquiditiesTest is Test, PosmTestSetup, LiquidityF | |||
| ); | |||
| lpm.modifyLiquidities(calls, _deadline); | |||
| } | |||
|
|
|||
| function test_weth_wrap_increaseLiquidity() public { | |||
There was a problem hiding this comment.
would love to see a test case that uses OPEN_DELTA to test that flow works too
HickupHH3
reviewed
Oct 21, 2024
Deivitto
reviewed
Oct 21, 2024
Deivitto
reviewed
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes