-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #642
Merged
Merged
Develop #642
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,18 +1,51 @@ | ||||||
from authentication.models import UserProfile | ||||||
from django.conf import settings | ||||||
from django.utils import timezone | ||||||
from abc import ABC, abstractmethod | ||||||
from telebot import types | ||||||
from telebot import types, ExceptionHandler | ||||||
|
||||||
import telebot | ||||||
import time | ||||||
import logging | ||||||
import traceback | ||||||
|
||||||
from telegram.models import TelegramConnection | ||||||
|
||||||
|
||||||
logger = logging.getLogger(__name__) | ||||||
|
||||||
telebot_instance = telebot.TeleBot(settings.TELEGRAM_BOT_API_KEY) | ||||||
|
||||||
class ExceptionHandler(ExceptionHandler): | ||||||
def handle(self, exception: Exception): | ||||||
# Timestamp for when the exception occurred | ||||||
timestamp = timezone.now().strftime("%d/%m/%Y, %H:%M:%S") | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion (bug_risk): Timestamp string format loses timezone information Consider including timezone information in the timestamp string format to aid in debugging across different timezones
Suggested change
|
||||||
|
||||||
logger.error(f"Custom exception handler triggered for {exception}: {timestamp}") | ||||||
traceback.print_exception(type(exception), exception, exception.__traceback__) | ||||||
|
||||||
# Detailed message with improved readability | ||||||
exception_message = ( | ||||||
f"**Exception Details**\n\n" | ||||||
f"**Exception Type:** `{exception.__class__.__name__}`\n" | ||||||
f"**Occurred At:** `{timestamp}`\n" | ||||||
f"\n**Traceback:**\n" | ||||||
f"```\n{''.join(traceback.format_exception(type(exception), exception, exception.__traceback__))}\n```" | ||||||
) | ||||||
|
||||||
sticker_emoji = "🪲🪲" # Customize as needed for better visibility | ||||||
TelegramMessenger.get_instance().send_message( | ||||||
chat_id=settings.TELEGRAM_BUG_REPORTER_CHANNEL_ID, | ||||||
text=( | ||||||
f"{sticker_emoji} **An error has occurred!** {sticker_emoji}\n\n" | ||||||
f"{exception_message}" | ||||||
), | ||||||
) | ||||||
|
||||||
|
||||||
telebot_instance = telebot.TeleBot( | ||||||
settings.TELEGRAM_BOT_API_KEY, exception_handler=ExceptionHandler() | ||||||
) | ||||||
|
||||||
|
||||||
MAX_REQUESTS_PER_SECOND = 30 | ||||||
|
||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): The ExceptionHandler class name shadows the imported ExceptionHandler from telebot
Consider renaming this class to something more specific like TelegramExceptionHandler to avoid naming conflicts and potential confusion