Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.3][URP] Backport of RTHandles Load/Store actions optimizations fix #7944

Closed
wants to merge 1 commit into from

Conversation

janice-see
Copy link
Contributor

@janice-see janice-see commented Aug 17, 2023

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

This is a backport of PR #6334 to fix reported foveation issues.
This particular fix was applied and only backported up till 2022.1. We received a request to backport it to 2021.3 as well.


Testing status

Verified that the foveation issues were fixed with the requester.


Comments to reviewers

This was a cherry-pick of the original PR, with some minor RTHandle -> RenderTargetHandle adjustments.

This is a backport of PR #6334 to fix reported foveation issues.
@janice-see janice-see requested review from a team as code owners August 17, 2023 21:38
@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the Unity SRP repo!
Please make sure to fill out the PR template as best you can to give reviewers as much information as possible.
If you have any questions (and you are a Unity employee) go to "#devs-renderpipe"

Copy link

@ernestasKupciunas ernestasKupciunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve without testing. Looks good.

@sebastienlagarde
Copy link
Contributor

Hi @janice-see . You must use private unity repo for change on 21.3, this public graphics repostiory is for "read only".

@janice-see janice-see closed this Sep 11, 2023
@janice-see janice-see deleted the 2021.3/urp-store-actions-fix branch September 11, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants