Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal/2023.1/staging #7948

Merged
merged 6 commits into from
Aug 23, 2023
Merged

Commits on Aug 7, 2023

  1. 2023.1/documentation staging

    Regular docs sync to main.
    RobJessop authored and Evergreen committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4966120 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. [Backport][2023.1][RPW] Missing Sprite previews

    https://jira.unity3d.com/browse/UUM-41498
    We wait for pipeline creation only for Materials, Models and Prefabs as they can have pipeline depend rendering.
    kirill-titov-u authored and Evergreen committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    aa6e3e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. [Backport][2023.1][VFX] Fix undefined behavior of SpawnerSetAttribute…

    … when an expression is connected to activation slot
    
    With the addition of activation slots in operators, the SpawnerSetAttribute operator can sometimes have 2 parameters instead of 1, if there is an expression connected to the activation slot.
    When this happens, the code assumes that the first parameter is the expression for the activation slot, and the second one is the attribute. However, this was never enforced when compiling the graph, leaving the order (and therefore the behavior) undefined, depending on the order in which they are stored by a Dictionary.
    We fixed it by explicitly sorting the values in the spawner system tasks. The sorting is done by expression index, to be consistent with the sorting in the particle system, with the exception the the activation slot, that is forced to be always first.
    
    The fact that the JIRA reproduces the issue activating "Runtime mode" is unrelated, it leads to a different order of the expressions that happens to trigger this.
    gabrieldelacruz authored and Evergreen committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9d7fd61 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. 2023.1/documentation staging

    Regular docs sync to main.
    RobJessop authored and Evergreen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    1e2612f View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. [2023.1][SpeedTree] Fix URP LOD CrossFade

    Fix [UUM-40046: SpeedTree Crossfade LOD transition doesn't work in URP](https://jira.unity3d.com/browse/UUM-40046) 
    
    Backport of: https://github.cds.internal.unity3d.com/unity/unity/pull/31026
    
    **CHANGES**
    
    - URP: the LOD_FADE_CROSSFADE keyword is now defined both for VS and PS instead of PS-only
    - Update SpeedTree8_PBRLit.shadergraph to let Unity handle Crossfade instead of using own LOD dithering
    - Added new unit test scene to URP_Terrain: `059_SpeedTree_LODTransition`
      - Enabled Crossfade on URP Settings asset using blue noise
      - Disabled XR tests, threshold required to ensure correctness is too low, always detects XR's 'Development Text' overlay
          - See [Failing Yamato Job](https://unity-ci.cds.internal.unity3d.com/job/25810642/results)
          - Error: 0.000770954532f | Threshold: 0.00075
    
     - [Slack chat](https://unity.slack.com/archives/C89KFUUCT/p1687810636577309)
    volkan-unity authored and Evergreen committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    41f73fe View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Configuration menu
    Copy the full SHA
    01c6cd4 View commit details
    Browse the repository at this point in the history