-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal/2023.1/staging #7948
Merged
Merged
Internal/2023.1/staging #7948
Commits on Aug 7, 2023
-
Regular docs sync to main.
Configuration menu - View commit details
-
Copy full SHA for 4966120 - Browse repository at this point
Copy the full SHA 4966120View commit details
Commits on Aug 8, 2023
-
[Backport][2023.1][RPW] Missing Sprite previews
https://jira.unity3d.com/browse/UUM-41498 We wait for pipeline creation only for Materials, Models and Prefabs as they can have pipeline depend rendering.
Configuration menu - View commit details
-
Copy full SHA for aa6e3e7 - Browse repository at this point
Copy the full SHA aa6e3e7View commit details
Commits on Aug 9, 2023
-
[Backport][2023.1][VFX] Fix undefined behavior of SpawnerSetAttribute…
… when an expression is connected to activation slot With the addition of activation slots in operators, the SpawnerSetAttribute operator can sometimes have 2 parameters instead of 1, if there is an expression connected to the activation slot. When this happens, the code assumes that the first parameter is the expression for the activation slot, and the second one is the attribute. However, this was never enforced when compiling the graph, leaving the order (and therefore the behavior) undefined, depending on the order in which they are stored by a Dictionary. We fixed it by explicitly sorting the values in the spawner system tasks. The sorting is done by expression index, to be consistent with the sorting in the particle system, with the exception the the activation slot, that is forced to be always first. The fact that the JIRA reproduces the issue activating "Runtime mode" is unrelated, it leads to a different order of the expressions that happens to trigger this.
Configuration menu - View commit details
-
Copy full SHA for 9d7fd61 - Browse repository at this point
Copy the full SHA 9d7fd61View commit details
Commits on Aug 15, 2023
-
Regular docs sync to main.
Configuration menu - View commit details
-
Copy full SHA for 1e2612f - Browse repository at this point
Copy the full SHA 1e2612fView commit details
Commits on Aug 16, 2023
-
[2023.1][SpeedTree] Fix URP LOD CrossFade
Fix [UUM-40046: SpeedTree Crossfade LOD transition doesn't work in URP](https://jira.unity3d.com/browse/UUM-40046) Backport of: https://github.cds.internal.unity3d.com/unity/unity/pull/31026 **CHANGES** - URP: the LOD_FADE_CROSSFADE keyword is now defined both for VS and PS instead of PS-only - Update SpeedTree8_PBRLit.shadergraph to let Unity handle Crossfade instead of using own LOD dithering - Added new unit test scene to URP_Terrain: `059_SpeedTree_LODTransition` - Enabled Crossfade on URP Settings asset using blue noise - Disabled XR tests, threshold required to ensure correctness is too low, always detects XR's 'Development Text' overlay - See [Failing Yamato Job](https://unity-ci.cds.internal.unity3d.com/job/25810642/results) - Error: 0.000770954532f | Threshold: 0.00075 - [Slack chat](https://unity.slack.com/archives/C89KFUUCT/p1687810636577309)
Configuration menu - View commit details
-
Copy full SHA for 41f73fe - Browse repository at this point
Copy the full SHA 41f73feView commit details
Commits on Aug 17, 2023
-
[Backport 2023.1][Tests] URP_Terrain Maintenance
Backporting Trunk PR: https://github.cds.internal.unity3d.com/unity/unity/pull/26870
Configuration menu - View commit details
-
Copy full SHA for 01c6cd4 - Browse repository at this point
Copy the full SHA 01c6cd4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.