Internal/master #8058
Merged
Internal/master #8058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing APIs requested by users: - get baking set for scene - load baking set for scene - trigger APV bake from script - Fix warning when baking dilation on URP - Fix missing wait on opencl buffer upload - Added Validity Based leak reduction mode to fix sampling artefacts - Fixed blending section in rendering debugger Update Documentation - Renamed 'Probe Volume' -> 'Adaptive Probe Volumes' - Added page for documenting the various APIs
Fixes the omission of depth buffer read declaration in the pass arguments for the URP Depth of Field post-processing effect. https://jira.unity3d.com/browse/UUM-68096
https://jira.unity3d.com/browse/UUM-62739 https://jira.unity3d.com/browse/UUM-62751 https://jira.unity3d.com/browse/UUM-62981 UUM-62739 Fixes for the Volume Component.⚠️ Only part 1 done. 2 and 3 should be ignored for the Testing  UUM-62751 Fixed a tooltip for the Material UI.  UUM-62981 Removed not only 3 dots menu but also warning and error buttons which appear when there's an empty object field. Text box is still there and below the list.
When the sampling position was located exactly on the boundary of the last brick of the cell, we would sample the wrong cell due to floating point precision issue. Fixed by clamping the brick index to the size of the cell.
Currently the intensity multiplier doesn't affect clouds, so that means, when trying to swap shadow maps on Sun/Moon directionnal light, even if both celestials bodies have an intensity multiplier at 0, we still see a pop ([video](https://gyazo.com/7bea0971a9e9e8a3e237c4a8bd3f1c2d)). This PR fixes it for both clouds and volumetric clouds. In the case we, one day, support multiple directionnal light with clouds (it has a cost), we'll need to remove this so that it works as the PBR sky (which supports multiple lights)
…anteed memory leak This PR provides a fix for https://jira.unity3d.com/browse/UUM-66351. The bug is caused by a design flaw in the IDeviceContext API. For the OpenCL implementation, events allocate, and must be released when they are no longer needed. The result is an unavoidable memory leak. The API doesn't provide a way to do this, so I've added it. It's also useful for the other implementations - currently, we are forced to hold on to certain data associated with events indefinitely, since we don't know when the user might want to query it. After discussing with team members, to keep the API symmetric, I've added a corresponding function to create events, and changed WriteBuffer() and ReadBuffer() to have the allocated event passed in, if the user wants to track completion. The result is that calling code which looked like this before: ```cs var evt = ctx.WriteBuffer(slice, arr); // unavoidable leak on this line ``` Will now look like this: ```cs var evt = ctx.CreateEvent(); // allocate event ctx.WriteBuffer(slice, arr, evt); // bind event to write ctx.DestroyEvent(evt); // clean up ``` Or optionally like this if the user just wants to fire-and-forget, and doesn't care about tracking completion: ```cs ctx.WriteBuffer(slice, arr); // return type is void, no leak ``` For any viewers unaware: This is a very new API added early so the APV could use it. It doesn't exist in any non-techstream releases yet. The flaw is blocking APV and causes instabilities in our tests.
In the initial rendering of the preview in the inspector window, the ambient color of the default sky may not be ready (black ambient color), due to the lag of GPU readback of the SH coefficients. The ambient color is not updated until the preview is updated by some triggers like hovering the cursor over the inspector. This PR fixes the issue by using the hard-coded value of the default sky's SH.
…ightMode" = "Universal2D" Fix missing pass name https://jira.unity3d.com/browse/UUM-36358
This PR updates the code owner and buginfo file to reflect changes in the graphics org. The code ownership is now assigned to @unity/material, which is a new GitHub team containing @apoorva-joshi, @mikkel-simonsen and @andresvalenciatellez.
This PR is adressing 3 tickets : - Wrong sets of culled objects are rendered with OnDemand shadow rendering https://jira.unity3d.com/browse/UUM-60823 - Expensive Culling for Non-Rendered Shadow Cascades https://jira.unity3d.com/browse/UUM-60917 - Use-after-free causing a crash under certain conditions https://jira.unity3d.com/browse/UUM-68625 The first ticket is a bug. Some shadow casters are culled when they shouldn't. The second ticket is a performance improvement. It allows some culling jobs not to be kicked at all when no shadow map update is needed for a given light. E.g when using OnDemand or OnEnable shadow rendering mode and no update was requested. It is also speeding up culling jobs by skipping receiver sphere culling for the shadow cascade which do not need an update. Implementation keypoints: - Fix the splitIndex not being passed to ShadowDrawingSettings. Simply store the splitIndex HDShadowCullingSplit and retrieve it when building the ShadowDrawingSettings - Refactor shadow caching code so that we know at culling time if a shadow cache will need to be updated or not - Discard culling jobs for the lights which have no shadow maps to update at all (and does not have the draw dynamic checkbox enabled) - Add support for a new `splitExclusionMask` API which allows SRP code to tell if culling should be skipped for some cascades (e.g. because of shadow caching) - Use the `splitExclusionMask` value internally to skip receiver sphere culling on C++ side - Pass the `splitExclusionMask` value to BRG OnPerformCulling callback so that EG, GRD or any BRG user code can beneficiate from it
Jira: UUM-62433 Steps to reproduce: - Start new project, import VFX graph - Right click -> create new VFX graph to open Template window - Without closing in, cause a domain reload (hit play, switch editor theme) => Observe window becomes empty 💡Proposed solution: closing window would be the best option here
Fixing missing moved from to make the API be auto updated. https://jira.unity3d.com/browse/UUM-61578
Disable unstable graphics test 10004_TerrainPathTracing in trunk. https://unity-ci.cds.internal.unity3d.com/job/35782432
*[See [this document](https://docs.google.com/document/d/1C4Vc7dOKgoZ2mNqMdugHDg-w6iN7iUYdlBQMGDmVS3E/edit) for details on what can land in 2023.3.]* *[Description of feature/change. Links to screenshots, design docs, user docs, etc. Link to Jira if applicable. Remember reviewers may be outside your team, and not know your feature/area that should be explained more.]*
Jira: UUM-65513 Reproduction steps: 1. Open the attached “VFX.zip” project 2. Open the “graph” asset from the Project Window 3. Dock the “graph” Window to the bottom of the UI Expected result: Floating panel is visible Actual result: Floating panel disappears Reproducible with: 2021.3.35f1, 2022.3.21f1, 2023.2.0a23, 2023.2.13f1 Not reproducible with: 2023.3.0b10 Fixed in: 2023.3.0a2 Reproducible on: Windows 11 Not reproducible on: no other environment tested Note: The 2023.3.0a1 version does not exist therefore cannot be tested Reproducible on any new project Issue appears if the floating panel is placed in the bottom left corner Downgrading from versions where it worked correctly, would usually fix the issue 
### Jira UUM-68044 Steps to reproduce: 1. Import (or reproduce) attached VFX 2. Observe first computed value in UX of Add => Expected intermediate status with `-` Actual results <img src="https://jira.unity3d.com/secure/attachment/1415346/1415346_image-2024-03-26-17-42-08-042.png" width="500" /> Expected results <img src="https://jira.unity3d.com/secure/attachment/1415345/1415345_image-2024-03-26-17-42-55-937.png" width="500" /> ### Jira UUM-68140 Steps to reproduce: 1. Open VFX 2. Create Update Context 3. Create block Set Axis X 4. Open Inspector change axis to Axis Z 5. Observe weird alignment of UI components Actual results <img src="https://jira.unity3d.com/secure/attachment/1416292/1416292_image-2024-03-27-17-28-31-096.png" width="500" /> Expected results <img src="https://jira.unity3d.com/secure/attachment/1416298/1416298_image-2024-03-27-17-39-57-915.png" width="500" />  In this same bug another issue is raised: When unlinking an edge on a collapsed port, the previously linked port is not hidden 
We have to disable native checks by default for the best burst jobs performance in GPU Resident Drawer. Additionally we never put NoAlias attribute along with native containers that required it which additionally allows compiler to improve performance. Performance Comparison: **Before:**   **After:**   50K Instances UpdateRendererData: Before: 24.55ms After: **19.34ms** 50K Instances Culling: Before: 2.34ms + 0.42ms = 2.76ms After: 1.31ms + 0.32ms = **1.63ms**
Set default projection orthographic for pixel perfect camera
… pass AfterRenderPostProcessing fix [UUM-68261](https://jira.unity3d.com/browse/UUM-68261) URP ignores resourceData.cameraColor when set in a user pass AfterRenderPostProcessing Update the RenderGraph blit with material sample to cover this scenario, and demonstrate how to use the ResourceData to avoid a copy blit back to the resource. This update also fixes bugs in the sample.
…from `LightingSpecular` This PR fixes the compiler error, described in UUM-48035, when using `single` precision: ``` Shader error in 'Lights Receiver URP/LightsReceiver': Program 'frag', error X8000: D3D11 Internal Compiler Error: Invalid Bytecode: Incompatible min precision type for operand #3 of opcode #40 (counts are 1-based). Expected int or uint. at line 47 (on metal) ```
Address and batch various minor bugfixes.
https://jira.unity3d.com/browse/UUM-67982 The update logic in the reflection probe atlas was not taking into account the runtime intensity of non real-time probes
Update .buginfo for areas: - SRP Workflow - Graphics Tools - SRP Architecture & API Amending the Codeowner file with same informations using handles - [unity/srp-workflows](https://github.cds.internal.unity3d.com/orgs/unity/teams/srp-workflows) - [graphics-tools](https://github.cds.internal.unity3d.com/orgs/unity/teams/graphics-tools) - [srp-architecture-api](https://github.cds.internal.unity3d.com/orgs/unity/teams/srp-architecture-api)
- Bumped SRP packages from 17.0.2 to 17.0.3. - For consistency, added the urp-config package to the editor manifest (see [thread](https://unity.slack.com/archives/C89KFUUCT/p1712083056017469)).
Update buginfo and code owners for VFX. - Visual Effects - Legacy area is merged with Visual Effects - Code owner file is updated
https://jira.unity3d.com/browse/UUM-67156 Before this change when we switched from URP to HDRP or vice versa we set globalRenderPipeline for the Shader systems twice. First we set `Shader.globalRenderPipeline = string.Empty` from destructor of the previous RP so we go from RP to BuiltIn. Then when we create RP we set `Shader.globalRenderPipeline = "RPName"` and we go from BuiltIn to RP. Each set of the globalRenderPipeline tag call `void Shader::SetGlobalRenderPipeline(const core::string& name) {}` and reload shaders. Now if we switch from any SRP to any SRP we will avoid intermediate step where we set an empty string to the `Shader.globalRenderPipeline` by checking `GraphicsSettings.currentRenderPipeline`
…ug panel why some settings are not applied. Fix this issue: https://jira.unity3d.com/browse/UUM-67130 Extracted the information why the GPU Resident drawer is not supported and added that feedback into the Rendering Debugger. Also, now the panel shows the warning and hides modifiying the GPU Resident Drawer if it is not enabled. The `RecreateIfNeeded`, is need to be handled per Render, as ther IsEnabled depends on settings that come directly from GraphicsSettings, and not from Render Pipeline Graphics settings, Therfore, when you changed something the GPU Resident drawer was not recreated. Added capabilities to the debug message box, to display new message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.