Internal/master #8063
Merged
Internal/master #8063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to fix Shaded-Wireframe rendering mode in URP when using RenderGraph, by introducing a "WireOverlay" `RasterRenderPass` that re-renders the scene for scene-view cameras if the mode is enabled. Since RenderGraph is now enabled by default, this was impacting the majority of our URP users using the latest betas. Jira: https://jira.unity3d.com/browse/UUM-67686
- Remove the VR and XR modules, and therefore defines, from the SRP smoke tests. This allows catching compilation errors faster, in the `PR` pipelines instead of in the QV (so far only the (QV) OnDemandImport project was testing the path where these 2 modules are not used). More context in that [thread](https://unity.slack.com/archives/C20E70CAC/p1702559984581049?thread_ts=1702552104.332429&cid=C20E70CAC). - This change prompted me to remove all other non SRP related packages/modules from the manifest. The goal with SRP Smoke tests is really just to make sure all packages compile, and having too much bloat even potentially hides unnecessary dependencies as this is not what an end user would have locally. The 2 graphics tests were removed as they needed the graphics test framework package, which depended on the VR and XR modules. - Add the SRP smoke tests project to `PR URP`.
Adds documentation for some of the helper methods in the URP shader library (and some methods from Core SRP shader library files that URP includes) To avoid this documentation task getting too large, I've focused on methods from: - Core.hlsl - Lighting.hlsl - Shadows.hlsl - ShaderVariablesFunction.hlsl - SpaceTransforms.hlsl (from SRP Core) I've aimed to cover methods/needs that are mentioned in our existing BiRP basic shaders documentation, so that users no longer accidentally find and use BiRP methods that don't work in URP. Preview site: https://docs-internal-preview.prd.it.unity3d.com/markg/urp-shader-methods/manual/use-built-in-shader-methods.html (needs VPN) Jira ticket: https://jira.unity3d.com/browse/DOCG-1019
JIRA: [UUM-69513](https://jira.unity3d.com/browse/UUM-69513) Immediate Mode is a rendergraph debug mode that is only supported by non-NRP RG in HDRP While we decide if we want to implement it for URP, it should be removed in URP so that users do not encounter issues with it.
… ONLY - DO NOT FORWARD PORT) Applied the changes to the UI to make the "enter play mode" settings clearer and more user friendly. https://jira.unity3d.com/browse/UUM-60957 
https://jira.unity3d.com/browse/UUM-68021 `Type.name` was used which accidentally instantiate HDRP Volume component of the same name. As both of them are Scriptable Object it was produced an exception when use it and not when it instantiates.
…xceptions Fix [UUM-66021](https://jira.unity3d.com/browse/UUM-66021) Fixed IndexOutOfRange errors in the decal system when using multiple cameras. This was caused by the static variable `m_DecalsVisibleThisFrame` being updated during culling, so the number of decals visible were only considered for the last camera the decal culling ran on.
Fix wrong error feedback with relative path, add a missing check using base path. Issue technically introduced at https://github.cds.internal.unity3d.com/unity/unity/commit/de946b09b4e9e9f3e06853c8f5465f5403f5ec96 but this isn't a regression since it's a new error feedback.
Currently in Unity 6, asmref files are sometimes used to bypass assembly visibility rules. In the future, asmref is no longer allowed so the current usage must be removed (see [RFC](https://docs.google.com/document/d/1SWAG19Ns5gnmbVl4WD-HT0f4DO2UVdiRj_YhX1o7J7E/edit#heading=h.9tfgs0fpr1tb)). This PR solves the sub-task [Remove asmref usage in main SRP package code](https://jira.unity3d.com/browse/XPIPELINE-917), part of the broader task [XPIPELINE-904](https://jira.unity3d.com/browse/XPIPELINE-904) to completely remove asmref usage from SRP code. Asmref usage in this PR originated from the need to access the internal "rawRenderQueue" property inside Material class. This PR just makes that property public API. Similar code was also found in ShaderGraph and fixed the same way.
Issue introduced at https://github.cds.internal.unity3d.com/unity/unity/commit/eb7e959a3fb7cae4dec459e2e5f5e7bd6ce28dd3 by this PR https://github.cds.internal.unity3d.com/unity/unity/pull/43339 Block is now consistent with Operator behavior https://github.cds.internal.unity3d.com/unity/unity/blob/8008bc0c1b747e1a435ebfe0b5685e80eb649be5/Packages/com.unity.visualeffectgraph/Editor/Models/Operators/Implementations/CustomHLSL.cs#L405
Currently in Unity 6, asmref files are sometimes used to bypass assembly visibility rules. In the future, asmref is no longer allowed so the current usage must be removed (see [RFC](https://docs.google.com/document/d/1SWAG19Ns5gnmbVl4WD-HT0f4DO2UVdiRj_YhX1o7J7E/edit#heading=h.9tfgs0fpr1tb)). This PR solves the sub-task [Remove asmref usage in SRP samples](https://jira.unity3d.com/browse/XPIPELINE-918), part of the broader task [XPIPELINE-904](https://jira.unity3d.com/browse/XPIPELINE-904) to completely remove asmref usage from SRP code. Asmref usage in this PR originated from the need to access HDRenderPipelineUI types, in order to display configuration UI to edit which settings an individual sample needs to be enabled. The asmref files are now removed, and instead the `HighDefition.Editor` assembly does a single `[assembly: InternalsVisibleTo("Unity.RenderPipelines.HighDefinition.Samples.Common.Editor")]` call to allow the editor code of HDRP Sample to access HDRP Editor internal types. In addition, asmdef files inside Core/HDRP Samples have been restrucuted and renamed to be more consistent with SRP naming conventions. The asmdef files are either "Runtime" or "Editor" assemblies, and the "Runtime" assemblies are not allowed to reference "Editor" assemblies. The new structure is displayed below:  Finally, I took an opportunity to replace some reflection code in the samples with a simpler callback. This PR is a follow-up to earlier PR https://github.cds.internal.unity3d.com/unity/unity/pull/47596.
Fix shader warnings in URP 2D template
Currently in Unity 6, asmref files are sometimes used to bypass assembly visibility rules. In the future, asmref is no longer allowed so the current usage must be removed (see [RFC](https://docs.google.com/document/d/1SWAG19Ns5gnmbVl4WD-HT0f4DO2UVdiRj_YhX1o7J7E/edit#heading=h.9tfgs0fpr1tb)). This PR solves the sub-task [Remove asmref usage in SRP tests](https://jira.unity3d.com/browse/XPIPELINE-919), part of the broader task [XPIPELINE-904](https://jira.unity3d.com/browse/XPIPELINE-904) to completely remove asmref usage from SRP code. SRP tests used asmrefs in 3 places: 1) **HDRP_RuntimeTests project** where the test `012-SVL_Check` contains script `SVLChecker.cs` which needs access to `GenerateShaderVariantList` inside the `com.unity.testframework.graphics` package. However since that type is public, there is no need to inject this script into that assembly. We simply add an asmdef file which contains a reference to the `UnityEngine.TestTools.Graphics` assembly. 2) **VisualEffectGraph_HDRP project** contains an editor-only `TemplateEditor.cs` script which used asmref to inject itself into `Unity.VisualEffectGraph.Editor` assembly. This is unnecessary that assembly is already accessible, we can just wrap the code in `#if UNITY_EDITOR` instead. 3) **UniversalGraphicsTest_2D project** contains an editor-only `AdditionalMenuItems.cs` script which used asmref to inject itself into `UnityEditor.TestTools.Graphics` assembly from `com.unity.testframework.graphics` package. This was also unnecessary, just wrapping the code in `#if UNITY_EDITOR` is enough. This PR is a follow-up to earlier PRs https://github.cds.internal.unity3d.com/unity/unity/pull/47596 and https://github.cds.internal.unity3d.com/unity/unity/pull/47609.
Post-processing alpha handling and output when the render target has an alpha channel and post-process alpha processing is enabled from the asset. The feature is opt-in. URP alpha output semantics are similar to HDRP. Enabled by toggling post-process alpha-processing from URPAsset->Post-Processing->Alpha Processing.  Alpha output is disabled by default to avoid regressions in existing projects. If disabled, the alpha output shaders are stripped. Alpha output warns if enabled, but the back-buffer format does not support alpha.  Alpha output requires selecting a back-buffer format with alpha from URPAsset->Quality->HDR/HDR Precision.  | Setting | Format. |Alpha Output| |------------|-----------|-------------| | SDR 32-bit | RGBA8 | Yes | | HDR 32-bit | RGB11f | No | | HDR 64-bit | RGBA16f | Yes | [**URP-1586**](https://jira.unity3d.com/browse/URP-1586) [**POI-1037**](https://jira.unity3d.com/browse/POI-1037)
Significantly improves the API in the Graphics Test Framework package and the Internal Editor API for capturing arbitrary Editor Windows. - Adds new API to the Internal Editor Utility class to take snapshots of arbitrary windows instead of just SceneView windows - Makes the older SceneView API obsolete - Adds new API to the Graphics Test Framework to write the snapshot to a Texture2D for full compatibility with the current testing paradigm - Refactors functionality for using this API on a SceneView window, leaving space for any other "special steps" done inside or outside the framework. - Significantly improves the API usability and testability by moving away from IEnumerator setup and to an async setup instead. - Updates the documentation around this functionality. ### Example captures #### Scene view with no modifications  #### Scene view with all overlays disabled  #### Scene view with most disabled + Debug Draw Mode  #### Custom editor window 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.