Internal/2021.3/staging #8068
Merged
Internal/2021.3/staging #8068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*[See [this document](https://docs.google.com/document/d/1C4Vc7dOKgoZ2mNqMdugHDg-w6iN7iUYdlBQMGDmVS3E/edit) for details on what can land in 2023.3.]* Fixed the Float2To8 packing function that was leaving parasite information in the lower bits. The following image shows in the middle and right square the result of packing and unpacking the color information with the function included in packing.hlsl and a corrected version.  *[Description of feature/change. Links to screenshots, design docs, user docs, etc. Link to Jira if applicable. Remember reviewers may be outside your team, and not know your feature/area that should be explained more.]* See above.
…d methods This is a backport of https://github.cds.internal.unity3d.com/unity/unity/pull/45224 Adds documentation for some of the helper methods in the URP shader library (and some methods from Core SRP shader library files that URP includes) To avoid this documentation task getting too large, I've focused on methods from: - Core.hlsl - Lighting.hlsl - Shadows.hlsl - ShaderVariablesFunction.hlsl - SpaceTransforms.hlsl (from SRP Core) I've aimed to cover methods/needs that are mentioned in our existing BiRP basic shaders documentation, so that users no longer accidentally find and use BiRP methods that don't work in URP. Preview site: https://docs-internal-preview.prd.it.unity3d.com/markg/urp-shader-methods/manual/use-built-in-shader-methods.html (needs VPN) Jira ticket: https://jira.unity3d.com/browse/DOCG-1019
Disable NRP for Apple Silicons as the support is not there on 21.3
*[Corrects the output type of the Branch node as per DOCATT-2055.]*
|
It appears that you made a non-draft PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.