Internal/2022.3/staging #8092
Merged
Internal/2022.3/staging #8092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address a few issues with shader graph shader variant limit.
…o have kicked everything This PR fixes Errors "glClientWaitSync: Expected application to have kicked everything until job: 96089 (possibly by calling glFlush)" are thrown in the Android Player on some devices with PowerVR Rogue GE8320 GPU. * Parent : https://jira.unity3d.com/browse/UUM-59572 * Backport : https://jira.unity3d.com/browse/UUM-63147
This PR fixes https://jira.unity3d.com/browse/UUM-70287 On Metal, shader compiler warns about using `int` on divide operations, and suggests to use `uint` instead to improve performance. This is fine so we do as the warning suggests.
…dreno GPUs with Vulkan Jira: https://jira.unity3d.com/browse/UUM-61728 Read the Comments to Reviewers section.
Backport of https://github.cds.internal.unity3d.com/unity/unity/pull/48921 This PR doesn't include SpeedTree9 changes as ST9 support is Unity6+. It also doesn't include the SpeedTree shadergraph/subgraph improvements in the original PR to keep changes minimal and only fix the bugs. | Shader | Leaf Facing | No-wind LOD Transition | | :-- | :-- | :-- | | BiRP | Fixed in PR | Already working | | URP_hlsl | Fixed in PR | Already working | | URP_sg | Already working for windy<br/>Fixed in PR no-wind | Fixed in PR | | HDRP_sg | Already working for windy<br/>Fixed in PR no-wind | Fixed in PR |
Partial fix for [UUM-31577](https://jira.unity3d.com/browse/UUM-31577) that eliminates a class of artifacts from High-Quality (PCSS) shadows. The fix is applicable to point and spot lights. Fix for [UUM-62513](https://jira.unity3d.com/browse/UUM-62513) that eliminates a class of artifacts from High-Quality (PCSS) shadows.
|
It appears that you made a non-draft PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.