-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Corrected behaviour of TrackedPoseDriver when no device is connected. #1823
base: develop
Are you sure you want to change the base?
Conversation
…cted with an additional test case mimicking the reported scenario.
@smnwttbr I don't have any XR devices so I'll add an XR QA instead. @UnityRyanC |
I won't be able to test this PR as I don't have a Mac (which the bug mentions was where the issue was reproduced on). I spoke with Manuel Gonzalez Solano, who does testing on PolySpatial and Apple Vision OS, who'll be able to test this once he's free later this week. I don't have permission to update reviewers on this PR, so @Pauliusd01 could you update the PR for me please? |
Okay, I dmed him on slack since I can't find him on github by name. |
@Pauliusd01 can you add me as reviewer? I don't seem to have permission to add myself |
Description
This fix is intended to fix reported behaviour in ISXB-699
.
Changes made
Modified behaviour when action reference is not set or when binding count is zero to not track position nor rotation.
Added a test case that is mimicking the reported behavior.
Notes
Requesting insights from XR team regarding any implications this might have since behavior wasn't previously covered properly in existing test cases. It also changes the behaviour commented inline in the implementation.
Checklist
Before review:
Changed
,Fixed
,Added
sections.([case %number%](https://issuetracker.unity3d.com/issues/...))
.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.