Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent SDL layouts from being created if a layout already exists #1924

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jgcodes2020
Copy link

Description

Unity's HID layout generator does not generate a layout if one already exists. I added this functionality to the Linux/SDL layout generator.

Changes made

Added a check to the SDL layout generator, preventing it from generating a layout if one exists already.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • FogBugz ticket attached, example ([case %number%](https://issuetracker.unity3d.com/issues/...)).
    • FogBugz is marked as "Resolved" with next release version correctly set.
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@unity-cla-assistant
Copy link

unity-cla-assistant commented May 12, 2024

CLA assistant check
All committers have signed the CLA.

@ekcoh ekcoh added the waiting-for-review The issue is scheduled to be reviewed by the Unity maintainers label May 14, 2024
@jgcodes2020 jgcodes2020 marked this pull request as ready for review May 14, 2024 12:55
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to prevent layout generation if a matching layout already exists. Thanks for the contribution.

@ekcoh ekcoh removed the waiting-for-review The issue is scheduled to be reviewed by the Unity maintainers label Sep 13, 2024
@ekcoh
Copy link
Collaborator

ekcoh commented Sep 13, 2024

Branch needs to be updated with changes from develop before it may be subject for QA and potential merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants