Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE: PR template text #2031

Merged
merged 2 commits into from
Oct 18, 2024
Merged

CHANGE: PR template text #2031

merged 2 commits into from
Oct 18, 2024

Conversation

Pauliusd01
Copy link
Collaborator

@Pauliusd01 Pauliusd01 commented Oct 18, 2024

Description

Changed the PR template to be closer to what we use for Editor PRs. It looks like this:

image

Hoping this helps with self rating on PR complexity/review needs and thus helps focus on the correct areas

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@Pauliusd01 Pauliusd01 changed the title Update pull_request_template.md CHANGE: PR template text Oct 18, 2024
@Pauliusd01 Pauliusd01 merged commit 40dc911 into develop Oct 18, 2024
4 of 77 checks passed
@Pauliusd01 Pauliusd01 deleted the update-pr-template branch October 18, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants