FIX: PointerEventData.pointerId is the same when simultaneously releasing and then pressing with another finger (ISXB-845) #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreire-unity
force-pushed
the
isxb-845-fix-pointer-down-same-frame-release-press
branch
3 times, most recently
from
a5fec7f
to
c645468
Compare
jfreire-unity
changed the title
ritamerkl
approved these changes
Oct 21, 2024
bmalrat
reviewed
Oct 21, 2024
Packages/com.unity.inputsystem/InputSystem/Plugins/UI/InputSystemUIInputModule.cs
Outdated
Show resolved
Hide resolved
Packages/com.unity.inputsystem/InputSystem/Plugins/UI/InputSystemUIInputModule.cs
Outdated
Show resolved
Hide resolved
| scene.leftChildReceiver.events.Clear(); | ||
|
|
||
| Assert.That(scene.eventSystem.IsPointerOverGameObject(), Is.False); | ||
| Assert.That(scene.eventSystem.IsPointerOverGameObject(touchScreen.deviceId), Is.False); |
There was a problem hiding this comment.
not sure that this assert is valid touchScreen.deviceId doesn't represent a pointer id.
There was a problem hiding this comment.
Removed. It was copied from previous tests
Pauliusd01
requested review from
stefanunity
and removed request for
Pauliusd01
stefanunity
approved these changes
Oct 23, 2024
jfreire-unity
force-pushed
the
isxb-845-fix-pointer-down-same-frame-release-press
branch
2 times, most recently
from
0781d9f
to
d41d05c
Compare
Covers the edge case of releasing one finger and pressing with another in the same frame.
… cache The commit also: - Expands unit test case - Removes m_PointerTouchControls as they were not being used anymore
jfreire-unity
force-pushed
the
isxb-845-fix-pointer-down-same-frame-release-press
branch
from
d41d05c
to
dd3127a
Compare
bmalrat
approved these changes
Oct 24, 2024
jfreire-unity
deleted the
isxb-845-fix-pointer-down-same-frame-release-press
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-845
A new pointer was not being created when we released and pressed a finger in the same frame, even though a new touchId was being produced by the native side.
This PR fixes that by looking into pointerIds instead of cached pointer controls. The cached pointer controls wouldn't reflect the control with the correct touchId when we release and press a touch control in the same frame.
Testing status & QA
Please test the bug project with and without this PR on a mobile device (Android or iOS)
For example, to reproduce the issue (more instructions in the bug report):
With the PR, in this example, step 3 should show the right panel green ✅
Overall Product Risks
Low
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: