Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: ISXB-1127 2D Vector Composite returns "IsPressed()" incorrectly when moving the joy stick #2034

Conversation

smnwttbr
Copy link
Collaborator

This reverts commit 0ddd534 which introduced a new bug ISXB-1127 (https://jira.unity3d.com/browse/ISXB-1127)

Description

The fix for ISXB-746 (https://jira.unity3d.com/browse/ISXB-746) introduced a condition where the IsPressed state on a control was incorrectly toggled. ISXB-746 is somewhat of a corner case and had a reasonable work-around, so it is acceptable to revert that fix as this issue (ISXB-1127) is a regression.

Testing status & QA

Local tests are passing.

Overall Product Risks

Low risk

  • Complexity: Low
  • Halo Effect: Small

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

…lled during Action handler (ISXB-746) (#1893)"

This reverts commit 0ddd534 which introduced a new bug ISXB-1127.
@unity-cla-assistant
Copy link

unity-cla-assistant commented Oct 23, 2024

CLA assistant check
All committers have signed the CLA.

@smnwttbr smnwttbr marked this pull request as draft October 23, 2024 01:37
@smnwttbr smnwttbr closed this Oct 23, 2024
@smnwttbr smnwttbr deleted the isxb-1127-2D-Vector-Composite-incorrectly-returns-IsPressed branch October 23, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants