-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: ISXB-1127 composite incorrectly returning IsPressed #2035
Conversation
I've let the bug reporter know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression. Reverting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked original repro steps with keyboard and a couple of mainstream controllers in Playmode and Player as well as sample scenes that seemed loosely related. Let me know if there's anything else that needs checking though
@@ -12,6 +12,7 @@ however, it has to be formatted properly to pass verification tests. | |||
|
|||
### Fixed | |||
- Fixed an issue causing the Action context menu to not show on right click when right clicking an action in the Input Action Editor [ISXB-1134](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1134). | |||
- Reverted changes from 0ddd534d8 (ISXB-746) which introduced a regression [ISXB-1127](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1127) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, missing period at end.
Description
ISXB-1127 is a regression caused by the fix for ISXB-746. It was decided to revert this fix, as it is a corner case with an acceptable workaround, and the regression is more serious.
Before releasing this fix, the original customer of ISXB-746 should be notified that the fix has been reverted.
Testing status & QA
Local tests passed.
Overall Product Risks
Low risk.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed
,Fixed
,Added
sections.Area_CanDoX
,Area_CanDoX_EvenIfYIsTheCase
,Area_WhenIDoX_AndYHappens_ThisIsTheResult
.During merge:
NEW: ___
.FIX: ___
.DOCS: ___
.CHANGE: ___
.RELEASE: 1.1.0-preview.3
.After merge: