Got example working with updated deps #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to remove warnings, re-enabled setCronEvents for plugin. Tested and working
tomhalley
changed the title
I cannot tell, I didn't write the code in the first place. Looking into it, it looks like it was either forgotten, or unnecessary code. As far as I remember, the backup rate feature worked fine, but I don't understand how. Maybe it didn't? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, saw you also did a commit to update the example. I may not have as put as much thought into the dependencies as I was trying to get the vulns to go away, but I tested it and got a backup being generated every minute. Think this will be useful on my project.
Curious why the
setCronEventfunction wasn't being called inserverless-plugin-db-backups.js?