Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add text/csv handling to the python sdk [RUDOLPH-90] #194

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Klaijan
Copy link

@Klaijan Klaijan commented Oct 15, 2024

This PR fixes the error when text/csv is passed to the param as below by adding the handling for text/csv

req = operations.PartitionRequest(
    partition_parameters=shared.PartitionParameters(
        files=files,
        strategy="fast",
        output_format="text/csv",
    )
)

To test:
Pull this branch and test on the local version of python client. Follow the guide here.
Or you could also install the client locally by pip install -v -e . to refer to the local version of the client.

JIRA Ticket

@Coniferish
Copy link
Collaborator

Coniferish commented Oct 16, 2024

Hey @Klaijan! Can you add this bug fix to the changelog? Austin created one just before leaving for us to track changes manually. We don't have any checks in CI for changes, so we'll just have to remember to do so for now.

@Klaijan Klaijan changed the title feat: add text/csv handling to the python sdk [RUDOLPH-90] fix: add text/csv handling to the python sdk [RUDOLPH-90] Oct 17, 2024
@Klaijan Klaijan marked this pull request as draft October 17, 2024 17:50
@Klaijan
Copy link
Author

Klaijan commented Oct 17, 2024

Error occur when try with 1-page pdf.
For extra context, the result is returned. But error was also raised.
1.pdf

unstructured_client.models.errors.sdkerror.SDKError: Unexpected response received (code: 200, type: text/plain; charset=utf-8): Status 200```

@Coniferish Coniferish force-pushed the klaijan/text-csv-response-type branch from 68e3955 to f81239d Compare October 23, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants