Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full SME(1) instruction support and STREAMING Groups #415
base: dev
Are you sure you want to change the base?
Full SME(1) instruction support and STREAMING Groups #415
Changes from all commits
cba8cff
34c1153
687d2a9
49fa390
4d1acc9
d13b7cc
60aeecc
89e6b6b
e671cc3
813b013
4e7c429
cae1005
8352b5a
b7a991e
a17b0fd
e1d2e39
26adf0d
377dd99
7903d46
93c3b6c
e12ccf1
d26ef3a
3adc299
e06387b
4cfe0eb
0a3fc93
a713f44
fac70b5
e906dd1
8c2a6bc
532f9af
3b4de2e
fb58957
c194858
7e5e32c
e664cc7
a064e9b
ffed626
66e54fd
762588b
59d7887
32948cf
5945bae
e15f354
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you double-checked the ordering of the concatenation? Ran it on ookami and I think these may be the wrong way round but worth double checking in case I've made a mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the spec:
i.e. N is concatonated onto the end of M (M:N)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think with "what the spec says" vs "observed values", the latter should probably be taken as the truth. So it's worth someone else double-checking that the values I've observed do go against what the spec says
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very odd and confusing... I've also checked on Ookami and Isambard-AI with the following asm programme:
Which after executing yields the following:
v0.b
={1, 1, 1, 1, 1, 1, 1, 1, 2, 2, 2, 2, 2, 2, 2, 2}
v0.s
={16843009, 16843009, 33686018, 33686018}
Which means the concatonation is
v1:v2
, NOTv2:v1
.I double checked that gdb doesn't display vector registers "in reverse" (i.e. left-hand most element is in fact
v0[0]
and notv0[15]
) using the final two instructions. Their results were:w12
= 16843009w13
= 33686018So yes, on hardware the concatonation is seemingly
vn:vm
.However, the spec and its pseudo code for
UMAXP
doesn't align with this... From this page, the pseudo code is as follows:Where it is clear that the concatonation according to this is
vm:vn
....In this instance, we should probably go with hardware. But it is quite annoying that the spec doesn't align with hardware on this, and that updating our code in-line with the spec still fixed the issue that was occuring!