AArch64 Capstone Update / SME2 support #429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinnWilkinson
force-pushed
the
sme2-support
branch
from
ce8e138
to
4921682
Compare
FinnWilkinson
requested review from
dANW34V3R,
jj16791,
JosephMoore25 and
ABenC377
FinnWilkinson
force-pushed
the
sme2-support
branch
from
e3f2486
to
8ea3727
Compare
ABenC377
requested changes
Sep 23, 2024
FinnWilkinson
changed the title
jj16791
requested changes
Oct 27, 2024
| if (((Opcode::AArch64_FMOVD0 <= metadata_.opcode && | ||
| metadata_.opcode <= Opcode::AArch64_FMOVS0) || | ||
| (Opcode::AArch64_FMOVDXHighr <= metadata_.opcode && | ||
| metadata_.opcode <= Opcode::AArch64_FMOVv8f16_ns)) && |
There was a problem hiding this comment.
Aren't the _ns instructions moving immediates into vector registers? (and thus aren't "move to general instructions")
There was a problem hiding this comment.
For this I replaced the numbers with Opcodes (and referred to the previous Capstone version to make sure they aligned). If this is the case then we can remove the _ns ones from this catch
There was a problem hiding this comment.
Double-checked and we should remove _ns from this catch
2 tasks
dANW34V3R
reviewed
Oct 29, 2024
…manual DDI0487K issue K.a 20th March 2024.
FinnWilkinson
force-pushed
the
sme2-support
branch
from
ec02455
to
e7d34e1
Compare
dANW34V3R
previously approved these changes
Nov 11, 2024
ABenC377
previously approved these changes
Nov 11, 2024
FinnWilkinson
dismissed stale reviews from ABenC377 and dANW34V3R
via
97fb519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates SimEng to work with a newer release of Capstone who's AArch64 engine is based on LLVM18, hence allowing SME2 support.
The reccommended version of LLVM has also been changed to 18.1.8 and the test suite has been updated to work with this version in order to dissassemble new AArch64 instructions.
Closes Issue #349
There have been large changes to Capstone internally for AArch64, some of the main ones which effect our current development / usage include:
A writeback from a pre/post index load/store is now included as an implicit destination. Hence, in instruction_execute the updated base address register is
resuts[0]rather thanresults[1](for example).Post index immediate operands are now included as part of the memory operand in
mem.disp. Post indexing with a register however is added as an additional operand.Aliasing can be dissabled for auto-sync architectures, and has been done for AArch64. This means expected registers for the operand are now correct and allows us to remove
revertalias()from instruction_metadata completely! The only oddity is themnemonicandoperandStrare still that of the alias. This means exceptions or debugging print statements may be confusing. To indicate aliases better, anisAliasbool has been added to the metadata and exception print out.Get automatic LLVM download and install working for version 18.1.8
Add AArch64 multi-vector operand enum decoding logic to instruction_decode