Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming conventions to match C++ library #58

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

apulsipher
Copy link
Contributor

@apulsipher apulsipher commented Dec 5, 2024

Make epiworldR version of LFMCMC consistent with changes in C++ library.

This shouldn't be merged until UofUEpiBio/epiworld#37 is merged.

@apulsipher apulsipher linked an issue Dec 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.15%. Comparing base (174263f) to head (50346c8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/LFMCMC.R 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   36.15%   36.15%           
=======================================
  Files          36       36           
  Lines        1975     1975           
=======================================
  Hits          714      714           
  Misses       1261     1261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DESCRIPTION Show resolved Hide resolved
R/LFMCMC.R Outdated Show resolved Hide resolved
Copy link
Member

@gvegayon gvegayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @apulsipher. Once the couple of comments are addressed, feel free to merge.

@apulsipher
Copy link
Contributor Author

Thank you, @apulsipher. Once the couple of comments are addressed, feel free to merge.

@gvegayon Thanks for looking at this! Have you also looked at the C++ library PR? I feel we should merge that one first

@apulsipher apulsipher merged commit c72336f into main Dec 10, 2024
14 checks passed
@apulsipher apulsipher deleted the 57-lfmcmc-naming-patch branch December 10, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update LFMCMC naming conventions to reflect changes in C++ library
2 participants