-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming variables for consistency with C++ library #66
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 36.61% 38.72% +2.11%
==========================================
Files 36 36
Lines 1991 2058 +67
==========================================
+ Hits 729 797 +68
+ Misses 1262 1261 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
@gvegayon Made the requested changes and brought in the latest from C++ library. Is this okay to merge? |
This PR brings renaming changes to bring the R package in line with the C++ library.
It also adds several getters that were on the C++ side, but not implemented in R until now.
Finally, it adds a fourth version number in the
DESCRIPTION
file to track patches on the R package that aren't correlated to updates on the C++ library.