Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming variables for consistency with C++ library #66

Merged
merged 9 commits into from
Dec 16, 2024

Conversation

apulsipher
Copy link
Contributor

@apulsipher apulsipher commented Dec 16, 2024

This PR brings renaming changes to bring the R package in line with the C++ library.

It also adds several getters that were on the C++ side, but not implemented in R until now.

Finally, it adds a fourth version number in the DESCRIPTION file to track patches on the R package that aren't correlated to updates on the C++ library.

@apulsipher apulsipher linked an issue Dec 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 94.89796% with 5 lines in your changes missing coverage. Please review.

Project coverage is 38.72%. Comparing base (6c3beac) to head (d2d6ca0).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/lfmcmc.cpp 94.23% 3 Missing ⚠️
R/LFMCMC.R 95.65% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   36.61%   38.72%   +2.11%     
==========================================
  Files          36       36              
  Lines        1991     2058      +67     
==========================================
+ Hits          729      797      +68     
+ Misses       1262     1261       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@gvegayon gvegayon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

DESCRIPTION Outdated Show resolved Hide resolved
NAMESPACE Show resolved Hide resolved
inst/tinytest/test-lfmcmc.R Outdated Show resolved Hide resolved
inst/tinytest/test-lfmcmc.R Outdated Show resolved Hide resolved
@apulsipher
Copy link
Contributor Author

@gvegayon Made the requested changes and brought in the latest from C++ library. Is this okay to merge?

@gvegayon gvegayon merged commit 43399ea into main Dec 16, 2024
12 checks passed
@gvegayon gvegayon deleted the 65-renaming-variables branch December 16, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming variables to be consistent with C++ library
2 participants