General Cleanup #29
Closed
General Cleanup #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added commands for generating documentation as well as creating a compile_commands.json file for compiling the C++ part of the module only (fast development iteration times). There's also a new rule for configuring the build directory for development.
Added basic content on installation to the documentation, fixed the names, warnings, errors, changed authors and copyright information, as well as remove some dummy content that was left over from template or other.
We ignore: .cache/: clangd cache .ipynb_checkpoints/: Jupyter Notebook data .pytest_cache/: Pytest data _build/: 'legacy' Sphinx output directory. build/: C++ output directory. __pycache__/: Python BC cache directory. comiple_commands.json: C++ compile commands. *.html: Quarto generated HTML. *.ipnyb: Any Jupyter Notebooks.
I would normally use spaces, but clangd for some reason is freaking out about spaces, so we're going with tabs until someone submits a patch.
Change whitespace and style, nothing functional was changed.
Refactor the binding code into multiple files, and get rid of llambdas. It's a lot cleaner/clearer now, I hope.
|
Don't merge this, the changes have been changed enough in #31 for it to not be worth it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24. The pull requests created later today will branch of this. I thought I already submitted a PR for this, but apparently not.