-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add output crs #73
Merged
Merged
Add output crs #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sgreenbury
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Hussein-Mahfouz for adding this feature and the changes, as discussed I'll go ahead and merge as all looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should close #72. It introduces a new configuration option to specify the output coordinate reference system (CRS) for various scripts. The changes ensure that all relevant data transformations and file outputs use the specified CRS from the configuration.
Configuration Changes:
output_crs
parameter to theconfig/base.toml
file to specify the desired output CRS.Parameters
class insrc/acbm/config.py
to include theoutput_crs
attribute and added a property method to access it.Script Updates:
scripts/0.1_run_osmox.py
,scripts/0_preprocess_inputs.py
,scripts/3.1_assign_primary_feasible_zones.py
,scripts/3.2.1_assign_primary_zone_edu.py
,scripts/3.2.2_assign_primary_zone_work.py
,scripts/3.2.3_assign_secondary_zone.py
,scripts/3.3_assign_facility_all.py
, andscripts/4_validation.py
to use theoutput_crs
from the configuration for CRS transformations and file outputs.scripts/3.1_assign_primary_feasible_zones.py
andscripts/3.2.3_assign_secondary_zone.py
to load correct travel_times based on config.boundary_geography (instead of hardcodedoa/
path)Function Updates:
plot_desire_lines
andplot_scatter_actual_reported
functions insrc/acbm/assigning/plots.py
to accept acrs
parameter and use it for CRS transformations.add_locations_to_activity_chains
function to use geopandas instead of a pyproj transformer, and to take in a crs parameter to convert the centroid point layer to (instead of hardcoded 4326)