Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SEPs): rename SEP(Scientific evaluation panel) to Fap(Facility access panel) #351

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

martin-trajanovski
Copy link
Contributor

Description

This PR aims to rename SEPs (Scientific evaluation panels) to Faps (Facility access panels).

Motivation and Context

After discussions with other facilities this seems to be more standard name for these kind of panels. We already did the change inside user-office-core and this needs to follow it.

How Has This Been Tested

  • e2e tests
  • manual tests

Fixes

https://jira.esss.lu.se/browse/SWAP-3635

Changes

Changes are only in renaming variables, files, classes and types.

Depends on

Tests included/Docs Updated?

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@martin-trajanovski martin-trajanovski self-assigned this Nov 30, 2023
@martin-trajanovski martin-trajanovski added the review: please A request for an ad-hoc review. label Nov 30, 2023
Copy link
Contributor

@yoganandaness yoganandaness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@martin-trajanovski martin-trajanovski merged commit cb21b9e into develop Nov 30, 2023
7 checks passed
@martin-trajanovski martin-trajanovski deleted the SWAP-3635-rename-sep-to-fap branch November 30, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review: please A request for an ad-hoc review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants