Fixes for OSX Compatibility #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version resets all the values after setting them for windows or darwin (OSX).
Needed cmth and stdlib.h (on OSX to compile) and sqrt was causing ft2 and ft3 to error since it cannot be used in constexpr in C++11.
|
this pull request can also fix build failure on GCC 6.x |
| @@ -31,6 +31,7 @@ install: all | |||
| ifneq ($(IMPLIB),) | |||
| install -m 644 $(IMPLIB) $(DESTDIR)$(libdir) | |||
| else | |||
| $(RM) $(libdir)/lib$(BASENAME).* | |||
There was a problem hiding this comment.
this broken the DESTDIR behavior
make DESTDIR="/tmp/makepkg/vapoursynth-plugin-fft3dfilter-git/pkg/vapoursynth-plugin-fft3dfilter-git" install
install -d /tmp/makepkg/vapoursynth-plugin-fft3dfilter-git/pkg/vapoursynth-plugin-fft3dfilter-git/usr/lib /tmp/makepkg/vapoursynth-plugin-fft3dfilter-git/pkg/vapoursynth-plugin-fft3dfilter-git/usr/lib/vapoursynth
rm -f /usr/lib/libvsfft3dfilter.*
rm: no se puede borrar '/usr/lib/libvsfft3dfilter.so.22': Permiso denegado
make: *** [GNUmakefile:31: install] Error 1
fixed if add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was having issues compiling in OSX and noticed that the flag changes for darwin were not sticking, instead it was using the flag changes that came after. Also ran across errors with sqrt being used in an constexpr, which would not compile. Additionally, cmath and stdlib needed to be defined.
P.S. Sorry for the mess, I'm new to Github and was trying to cut down on all the forks I created trying to make a few fixes.