Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributor guidelines #91

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

n-eiling
Copy link
Member

@n-eiling n-eiling commented Nov 13, 2024

Addressen #89

also adds a CODEOWNERS file

Signed-off-by: Niklas Eiling <[email protected]>
@n-eiling n-eiling requested a review from stv0g November 13, 2024 13:47
@stv0g stv0g changed the title update contributor guidelines Update contributor guidelines Nov 14, 2024
Copy link
Contributor

@stv0g stv0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall :) Thanks for caring about it!

Did you see that we also have a CONTRIBUTING.md in VILLASnode?
We should remove it from there and replace it with a simple reference to the one in the documentation repo.

docs/node/development/contributing.md Show resolved Hide resolved
docs/node/development/contributing.md Show resolved Hide resolved
docs/node/development/contributing.md Show resolved Hide resolved
docs/node/development/contributing.md Outdated Show resolved Hide resolved
@n-eiling
Copy link
Member Author

@stv0g ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants