Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove startContainers.sh in favor of Docker Compose #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gilbertotcc
Copy link

This PR would like to be an enhancement of the project. It removes startContainers.sh script in favor of Docker Compose that runs the containers required by the examples.

Furthermore, by means of gradle-docker-compose-plugin Gradle plugin (see here), Docker Compose is fully integrated with Gradle. That means:

  • compose up and compose down are made before and after tests;
  • containers can be started with composeUp task and stopped with composeDown task.

@gilbertotcc gilbertotcc changed the title Remove startContainers.sh in favor of Docker Compose (WIP) Remove startContainers.sh in favor of Docker Compose Mar 31, 2019
@gilbertotcc
Copy link
Author

Some tests fail. I think is due to some library versions. I'm going to fix them. I've already have a working branch at gilbertotcc/IDDD_Samples. I just need to check which are the libraries that I have to update (making less changes as possible).

@gilbertotcc
Copy link
Author

Issue has been fixed. See commit Fix database creation and update dependencies for changes.

@gilbertotcc gilbertotcc changed the title (WIP) Remove startContainers.sh in favor of Docker Compose Remove startContainers.sh in favor of Docker Compose Mar 31, 2019
@manuelprinz manuelprinz mentioned this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant