Skip to content

Commit

Permalink
[MIG] stock_manual_transfer: Migration to 18.0
Browse files Browse the repository at this point in the history
Changelog:
- Bump version to 18.0.1.0.0
- Use location_final_id instead of location_dest_id because are not
  getting the values from stock rules but operation type, and location
  in the rule are saved on location_final_id [1]
- Add Internal Manual Transfer menu to respect the style of the current
  Operation menu of Inventory
- Add path to action to show a meaningful url
  (/odoo/stock_manual_transfer)
- General changes of this version (tree to list, chatter block, use
  self.env._, remove no needed invisible field)
- Update translations and documentation

References:
- [1] odoo/odoo@11e69870
  • Loading branch information
rolandojduartem committed Feb 27, 2025
1 parent e92ca66 commit 5812c50
Show file tree
Hide file tree
Showing 12 changed files with 30 additions and 60 deletions.
2 changes: 1 addition & 1 deletion stock_manual_transfer/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Stock Manual Transfer:

This module allows you to trigger transfers using a specific route, as it were triggered by a reordering rule.

- In order to be able to make the transfer, the user must belong to the stock manual transfer group:
- In order to be able to make the transfer, the user must belong to the Can make manual transfers group:

.. image:: ./static/description/manual_transfer_group.png
:alt: Manual transfer group
Expand Down
2 changes: 1 addition & 1 deletion stock_manual_transfer/__manifest__.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"website": "https://www.vauxoo.com",
"license": "LGPL-3",
"category": "Inventory/Inventory",
"version": "17.0.1.0.0",
"version": "18.0.1.0.0",
"depends": [
"stock",
],
Expand Down
13 changes: 4 additions & 9 deletions stock_manual_transfer/i18n/es.po
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
#
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 17.0+e\n"
"Project-Id-Version: Odoo Server 18.0+e\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2024-05-22 02:09+0000\n"
"PO-Revision-Date: 2024-05-22 02:09+0000\n"
"POT-Creation-Date: 2025-02-27 04:26+0000\n"
"PO-Revision-Date: 2025-02-27 04:26+0000\n"
"Last-Translator: \n"
"Language-Team: \n"
"MIME-Version: 1.0\n"
Expand Down Expand Up @@ -207,9 +207,6 @@ msgstr "Nombre"
#. module: stock_manual_transfer
#. odoo-python
#: code:addons/stock_manual_transfer/models/stock_manual_transfer.py:0
#: code:addons/stock_manual_transfer/models/stock_manual_transfer.py:0
#: code:addons/stock_manual_transfer/models/stock_manual_transfer.py:0
#, python-format
msgid "New"
msgstr "Nueva"

Expand Down Expand Up @@ -262,7 +259,7 @@ msgstr "Ruta preferida"
#: model:ir.model,name:stock_manual_transfer.model_procurement_group
#: model:ir.model.fields,field_description:stock_manual_transfer.field_stock_manual_transfer__procurement_group_id
msgid "Procurement Group"
msgstr "Grupo de aprovisionamiento"
msgstr "Grupo de abastecimiento"

#. module: stock_manual_transfer
#: model:ir.model.fields,field_description:stock_manual_transfer.field_stock_manual_transfer_line__product_id
Expand Down Expand Up @@ -320,7 +317,6 @@ msgstr ""
#. module: stock_manual_transfer
#. odoo-python
#: code:addons/stock_manual_transfer/models/stock_manual_transfer.py:0
#, python-format
msgid ""
"The selected route doesn't have configured rules on the selected warehouse."
msgstr ""
Expand Down Expand Up @@ -387,7 +383,6 @@ msgstr ""
#. module: stock_manual_transfer
#. odoo-python
#: code:addons/stock_manual_transfer/models/stock_manual_transfer.py:0
#, python-format
msgid ""
"You can not delete a validated transfer.\n"
"- Record: %s"
Expand Down
32 changes: 0 additions & 32 deletions stock_manual_transfer/migrations/17.0.1.0.0/pre-migration.py

This file was deleted.

12 changes: 7 additions & 5 deletions stock_manual_transfer/models/stock_manual_transfer.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from odoo import _, api, fields, models
from odoo import api, fields, models
from odoo.exceptions import ValidationError


Expand All @@ -12,7 +12,7 @@ class StockManualTransfer(models.Model):
copy=False,
readonly=True,
index=True,
default=lambda self: _("New"),
default=lambda self: self.env._("New"),
)
warehouse_id = fields.Many2one(
"stock.warehouse",
Expand Down Expand Up @@ -63,7 +63,9 @@ def action_validate(self):
return
route = self.route_id
if self.warehouse_id not in route.rule_ids.warehouse_id:
raise ValidationError(_("The selected route doesn't have configured rules on the selected warehouse."))
raise ValidationError(
self.env._("The selected route doesn't have configured rules on the selected warehouse.")
)

procurement_group = self.env["procurement.group"].create({"name": self.name})
values = {
Expand Down Expand Up @@ -91,7 +93,7 @@ def _unlink_except_state_valid(self):
for record in self:
if record.state == "valid":
raise ValidationError(
_(
self.env._(
"You can not delete a validated transfer.\n- Record: %s",
record.name,
)
Expand All @@ -100,7 +102,7 @@ def _unlink_except_state_valid(self):
@api.model_create_multi
def create(self, vals_list):
for vals in vals_list:
if vals.get("name", _("New")) == _("New"):
if vals.get("name", self.env._("New")) == self.env._("New"):
vals["name"] = self.env["ir.sequence"].next_by_code(self._name)
return super().create(vals_list)

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified stock_manual_transfer/static/description/manual_transfer_group.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified stock_manual_transfer/static/description/stock_move_created.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion stock_manual_transfer/tests/test_stock_manual_transfer.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def test_01_manual_transfer(self):
"product_id": self.product.id,
"quantity": 1.0,
"location_id": self.location_suppliers.id,
"location_dest_id": self.warehouse.lot_stock_id.id,
"location_final_id": self.warehouse.lot_stock_id.id,
"origin": expected_name,
"state": "assigned",
},
Expand Down
27 changes: 16 additions & 11 deletions stock_manual_transfer/views/stock_manual_transfer_views.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<field name="arch" type="xml">
<form string="Manual Transfer">
<header>
<field name="picking_ids" invisible="1" />
<button
name="action_validate"
type="object"
Expand Down Expand Up @@ -40,14 +39,14 @@
<notebook>
<page string="Transfer Lines" name="transfer_lines">
<field name="transfer_line_ids" nolabel="1" readonly="state != 'draft'">
<tree editable="bottom">
<list editable="bottom">
<field name="sequence" widget="handle" />
<field name="product_id" />
<field name="product_uom_qty" />
<field name="product_uom_id" column_invisible="1" />
<field name="product_uom_id" groups="uom.group_uom" optional="show" />
<field name="product_uom_category_id" column_invisible="True" />
</tree>
</list>
<form>
<group>
<group>
Expand All @@ -63,30 +62,28 @@
</page>
</notebook>
</sheet>
<div class="oe_chatter">
<field name="message_follower_ids" />
<field name="message_ids" />
</div>
<chatter />
</form>
</field>
</record>

<record id="stock_manual_transfer_tree_view" model="ir.ui.view">
<field name="name">stock.manual_transfer.tree</field>
<field name="name">stock.manual_transfer.list</field>
<field name="model">stock.manual_transfer</field>
<field name="arch" type="xml">
<tree>
<list>
<field name="name" />
<field name="warehouse_id" readonly="state != 'draft'" />
<field name="date_planned" readonly="state != 'draft'" />
<field name="route_id" readonly="state != 'draft'" />
<field name="state" />
</tree>
</list>
</field>
</record>

<record id="stock_manual_transfer_action" model="ir.actions.act_window">
<field name="name">Manual Transfer</field>
<field name="path">stock_manual_transfer</field>
<field name="res_model">stock.manual_transfer</field>
<field name="help" type="html">
<p class="oe_view_nocontent_create">
Expand All @@ -95,10 +92,18 @@
</field>
</record>

<menuitem
id="menu_stock_manual_transfer"
name="Internal Manual Transfer"
parent="stock.menu_stock_warehouse_mgmt"
sequence="3"
groups="stock_manual_transfer.group_user"
/>

<menuitem
action="stock_manual_transfer_action"
id="menu_stock_manual_transfer_act"
parent="stock.menu_stock_warehouse_mgmt"
parent="menu_stock_manual_transfer"
sequence="40"
groups="stock_manual_transfer.group_user"
/>
Expand Down

0 comments on commit 5812c50

Please sign in to comment.