[IMP] default_warehouse_from_sale_team: hook to fill allowed sales teams T#79454 #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisg123v
requested review from
hugho-ad,
desdelinux,
TeposteAJ,
xmglord and
CLaurelB
xmglord
suggested changes
Jul 6, 2024
|
commit description: |
luisg123v
force-pushed
the
17.0-default_hook_allowed-luisg
branch
3 times, most recently
from
b941986 to
94c7cc1
Compare
|
@xmglord Fixes to commit messages applied. |
Not applied yet |
luisg123v
changed the title
Implement a hook to fill allowed sales teams in users that are already a member of any team. Since this module implements a feature to restrict which sales teams a user may be a member of, users that already belong to any team are configured to be allowed for those teams, to avoid inconsistencies between allowed and already-configured memberships. In other words, if a user already belongs to a team, it most likely means they should be allowed to belong to it, so allowance is granted.
luisg123v
force-pushed
the
17.0-default_hook_allowed-luisg
branch
from
94c7cc1 to
df6ae5d
Compare
desdelinux
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a hook to fill allowed sales teams in users that are already
a member of any team.
Since this module implements a feature to restrict which sales teams a
user may be a member of, users that already belong to any team are
configured to be allowed for those teams, to avoid
inconsistencies between allowed and already-configured memberships. In
other words, if a user already belongs to a team, it most likely means
they should be allowed to belong to it, so allowance is granted.