Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] typ: Missing label in routes view #1682

Closed
wants to merge 1 commit into from
Closed

[FIX] typ: Missing label in routes view #1682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stock_manual_transfer/views/stock_route_views.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<field name="model">stock.route</field>
<field name="inherit_id" ref="stock.stock_location_route_form_view" />
<field name="arch" type="xml">
<xpath expr="//field[@name='warehouse_selectable']" position="after">
<xpath expr="//div[field[@name='warehouse_ids']]" position="after">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For readability, I think it would be better to reference the selectable field:

Suggested change
<xpath expr="//div[field[@name='warehouse_ids']]" position="after">
<xpath expr="//div[field[@name='warehouse_selectable']]" position="after">

(I had to check original code to understand this)

<field name="manual_transfer_selectable" string="Manual transfers" />
</xpath>
</field>
Expand Down
Loading