Special color for exported symbols

Imports have their own color, so exports can too
Vector35 · Nov 17, 2023 · 7259170 · 7259170
1 parent c798413
commit 7259170
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 0 deletions.
diff --git a/binaryninjacore.h b/binaryninjacore.h
@@ -1798,6 +1798,7 @@ extern "C"
 		DataSymbolColor,
 		StackVariableColor,
 		ImportColor,
+		ExportColor,
 		InstructionHighlightColor,
 		RelatedInstructionHighlightColor,
 		TokenHighlightColor,

diff --git a/examples/triage/exports.cpp b/examples/triage/exports.cpp
@@ -100,6 +100,8 @@ QVariant GenericExportsModel::data(const QModelIndex& index, int role) const
 	case Qt::ForegroundRole:
 		if (index.column() == AddressColumn)
 			return getThemeColor(AddressColor);
+		if (index.column() == NameColumn)
+			return getThemeColor(ExportColor);
 		break;
 	default:
 		break;

diff --git a/examples/triage/imports.cpp b/examples/triage/imports.cpp
@@ -71,6 +71,8 @@ QVariant GenericImportsModel::data(const QModelIndex& index, int role) const
 	case Qt::ForegroundRole:
 		if (index.column() == 0)
 			return getThemeColor(AddressColor);
+		if (index.column() == m_nameCol)
+			return getThemeColor(ImportColor);
 		break;
 	default:
 		break;

diff --git a/themes/dark-blue.theme b/themes/dark-blue.theme
@@ -79,6 +79,7 @@
         "dataSymbolColor":                      "cyan",
         "stackVariableColor":                   ["+", "green", "content"],
         "importColor":                          "orange",
+        "exportColor":                          "magenta",
         "instructionHighlightColor":            "selectionLight",
         "tokenHighlightColor":                  "red",
         "annotationColor":                      "magenta",

diff --git a/themes/high-contrast.theme b/themes/high-contrast.theme
@@ -78,6 +78,7 @@
         "dataSymbolColor":                      "cyan",
         "stackVariableColor":                   ["+", "green", "content"],
         "importColor":                          "orange",
+        "exportColor":                          "magenta",
         "instructionHighlightColor":            "selectionLight",
         "tokenHighlightColor":                  "red",
         "annotationColor":                      "red",

diff --git a/themes/solarized-dark.theme b/themes/solarized-dark.theme
@@ -75,6 +75,7 @@
         "dataSymbolColor":                      "cyan",
         "stackVariableColor":                   "violet",
         "importColor":                          "orange",
+        "exportColor":                          "magenta",
         "instructionHighlightColor":            "secondary",
         "tokenHighlightColor":                  ["+", "secondary", "orange"],
         "annotationColor":                      "magenta",

diff --git a/themes/solarized-light.theme b/themes/solarized-light.theme
@@ -75,6 +75,7 @@
         "dataSymbolColor":                      "cyan",
         "stackVariableColor":                   "violet",
         "importColor":                          "orange",
+        "exportColor":                          "violet",
         "instructionHighlightColor":            "secondary",
         "tokenHighlightColor":                  ["+", "secondary", "orange"],
         "annotationColor":                      "magenta",

diff --git a/ui/theme.h b/ui/theme.h
@@ -49,6 +49,8 @@ void BINARYNINJAUIAPI addJsonTheme(const char* json);
 QColor BINARYNINJAUIAPI getThemeColor(BNThemeColor color);
 QColor BINARYNINJAUIAPI getTokenColor(QWidget* widget, BNInstructionTextTokenType token);
 QColor BINARYNINJAUIAPI getTypeClassColor(const QWidget* widget, BNTypeClass typeClass);
+std::optional<QColor> BINARYNINJAUIAPI getSymbolColor(SymbolRef symbol);
+std::optional<QColor> BINARYNINJAUIAPI getSymbolColor(BNSymbolType type, BNSymbolBinding binding);
 
 QColor BINARYNINJAUIAPI avgColor(QColor a, QColor b);
 QColor BINARYNINJAUIAPI mixColor(QColor a, QColor b, uint8_t mix);