Implement rust TemporaryFile #5430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emesare
reviewed
Jul 23, 2024
| major: info_raw.major, | ||
| minor: info_raw.minor, | ||
| build: info_raw.build, | ||
| channel: unsafe { string::BnString::from_raw(info_raw.channel) }, |
There was a problem hiding this comment.
This will crash on local builds of binary ninja due to a bug (unrelated to this PR) for any other reviewers. I don't think this should block as the fix is in the core.
There was a problem hiding this comment.
Fix is in latest dev for the crash so no cause for alarm anymore :)
emesare
reviewed
Jul 24, 2024
| let data = DataBuffer::new(DATA).unwrap(); | ||
| let tmp_file = TemporaryFile::new_from_contents(&data).unwrap(); | ||
| let data_read = tmp_file.contents(); | ||
| assert_eq!(data_read.get_data(), DATA); |
There was a problem hiding this comment.
I cannot get this to work under headless:
assertion `left == right` failed
left: []
right: [116, 101, 115, 116, 32, 49, 50, 51]
|
Other than the comments I left LGTM If temporary files do not work under headless (???) then they will IMO have to be omitted until that is resolved. |
emesare
force-pushed
the
more-functions
branch
2 times, most recently
from
85a26f2 to
7fef169
Compare
Comment on lines
+102
to
+103
| pub fn is_shutdown_requested() { | ||
| unsafe { binaryninjacore_sys::BNIsShutdownRequested() }; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
emesare
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm slowly implementing functions from the Core API that are missing on the rust API.