-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new setting to skip HEAD requests for localhost servers #5481
Add new setting to skip HEAD requests for localhost servers #5481
Conversation
They are conflicting with the demangler-generated real vtable types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to break support for file.ptr
redirection (and would break .pd_
compression if it were supported) because the symbol search thinks it can resolve the pdb file, but gets a 404 and fails back to the next symbol server instead of trying the next option in the current server. Resolving this might be a bit tricky (I can't believe Rust still doesn't have generators) since handling file.ptr
involves doing two requests and some parsing. So some redirection of control flow will be needed to get this to work properly, likely moving the call to read_from_sym_store
out of load_from_file
and maybe dropping sym_store_exists
as a concept and just loading it all in one shot. I can implement this if you want, or feel free to do it yourself.
3302252
to
5840608
Compare
7546cb3
to
7037691
Compare
Not handling However, if that logic is a requirement for you, I'm perfectly fine with you adding it; I just don't have an exemplar localhost proxy server to test further changes, haha |
I'd really prefer to not stealth break functionality if possible, given I have no idea if people are relying on this. I've been testing with |
Just pushed an update for this that does the implementation I described above. Let me know if it works for the same servers that your commit did, and if so I'm just going to merge that. |
Yep, it still seems to work, thank you! |
8864144
to
0991538
Compare
Merged that commit to dev, so closing this now |
Proxy servers such as SymProxyCloud don't respond to
HEAD
requests, so this PR adds a new setting that allows the user to skip file existence checks using aHEAD
request.Note that this setting only affects
localhost
servers, not other remote servers.