implement rust workflow #5538
Closed
implement rust workflow #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emesare
reviewed
Jul 8, 2024
Comment on lines
+291
to
+311
| pub fn register_activity<I>(&self, activify: &Activity, subactivities: I) -> Activity | ||
| where | ||
| I: IntoIterator, | ||
| I::Item: IntoActivityName, | ||
| { | ||
| let subactivities_raw: Vec<BnString> = subactivities | ||
| .into_iter() | ||
| .map(|x| x.activity_name()) | ||
| .collect(); | ||
| let mut subactivities_ptr: Vec<*const _> = | ||
| subactivities_raw.iter().map(|x| x.as_ptr()).collect(); | ||
| let result = unsafe { | ||
| BNWorkflowRegisterActivity( | ||
| self.as_raw(), | ||
| activify.as_raw(), | ||
| subactivities_ptr.as_mut_ptr(), | ||
| subactivities_ptr.len(), | ||
| ) | ||
| }; | ||
| unsafe { Activity::from_raw(ptr::NonNull::new(result).unwrap()) } | ||
| } |
There was a problem hiding this comment.
This does not work, given:
let work = Workflow::new("testWorkflow");
let activity = Activity::new_with_action("test", |ctx| {});
work.register_activity::<Vec<String>>(&activity, vec![]);
work.register(
r#"{
"title" : "Rust workflow",
"description" : "",
"capabilities" : []
}"#,
)
.expect("workflow is registered");
work.insert("core.function.translateTailCalls", ["test"]);I don't know why but it fails in Workflow::Validate but it shouldn't fail if there is no subactivity.
Before we can merge this we need to figure out why this happens.
emesare
reviewed
Jul 8, 2024
| /// | ||
| /// * `activity` - the Activity to register | ||
| /// * `subactivities` - the list of Activities to assign | ||
| pub fn register_activity<I>(&self, activify: &Activity, subactivities: I) -> Activity |
|
Added with 3a94767, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.