Fix inlining of CFString literals
#67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure when this broke but on 4.3.6550-dev (1ae64a95) inlining of `CFString` literals when viewing a Mach-O binary is not working at all. This is caused by the type of global constant `CFString`s in the `__cfstring` section being typed `__NSConstantString`. However this plugin is expecting them to be `CFString`. This PR adds an additional check on the string's variable type to see if it is an `__NSConstantString`. There's probably a more robust solution to this but it at least gets the `CFString` inlining working again.
WeiN76LQh
pushed a commit
to WeiN76LQh/binaryninja-api
that referenced
this pull request
Jan 4, 2025
Basically just copied from the [workflow objc plugin](https://github.com/Vector35/workflow_objc) with [PR Vector35#67](Vector35/workflow_objc#67) applied. Ideally this would not be a copy and these 2 codebases would share the code but its unclear if Vector35 would want to import the Objective-C workflow plugin into the BN API repo and what that would look like. So this is an intermediary solution to get `CFString` inlining working in DSC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure when this broke but on 4.3.6550-dev (1ae64a95) inlining of
CFStringliterals when viewing a Mach-O binary is not working at all. This is caused by the type of global constantCFStrings in the__cfstringsection being typed__NSConstantString. However this plugin is expecting them to beCFString.This PR adds an additional check on the string's variable type to see if it is an
__NSConstantString. There's probably a more robust solution to this but it at least gets theCFStringinlining working again.