Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages/viewer): update peer dependencies,... #93

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

Schlomoh
Copy link
Collaborator

@Schlomoh Schlomoh commented Nov 6, 2024

...add Storybook configuration, implement robust styling and remove postcss config files.

This pull request introduces several enhancements and new features, primarily focusing on integrating Storybook, improving PostCSS configuration, and refining component properties and defaults.

Storybook Integration:

  • Added Storybook configuration and dependencies (apps/official-website/vite.config.mts, nx.json, package.json, packages/viewer/.storybook/main.ts, packages/viewer/.storybook/preview.ts). [1] [2] [3] [4] [5]

PostCSS Configuration:

  • Integrated PostCSS plugins directly into the Vite configuration and removed the old PostCSS configuration files (apps/official-website/vite.config.mts, packages/viewer/postcss.viewer.config.js). [1] [2]

Component Enhancements:

  • Enhanced InfoPopover component with additional properties and focus management (packages/viewer/src/components/info-popover.tsx).
  • Added default options and improved type definitions for SceneCamera, SceneControls, and SceneGrid components (packages/viewer/src/components/scene/scene-camera.tsx, packages/viewer/src/components/scene/scene-controls.tsx, packages/viewer/src/components/scene/index.ts). [1] [2] [3]

Dependency Updates:

  • Updated and added new dependencies related to Storybook and PostCSS in package.json files (package.json, packages/hooks/package.json, packages/viewer/package.json). [1] [2] [3] [4] [5]

ESLint Configuration:

  • Updated ESLint configuration to ignore Storybook static files and adjusted dependency rules (packages/viewer/.eslintrc.json). [1] [2] [3] [4] [5]

…uration, implement robust styling and remove postcss config files
@Schlomoh Schlomoh merged commit 7df00eb into main Nov 6, 2024
3 checks passed
@Schlomoh Schlomoh deleted the fix/viewer branch November 6, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packages/viewer - Add integration tests for viewer and the vctrl/hooks integration
1 participant