forked from SFTtech/openage
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide missing GL_DEBUG definitions (fix compile on Mac) #2
Open
Birch-san
wants to merge
7
commits into
VelorumS:gui-gl-context
Choose a base branch
from
Birch-san:gui-gl-context-fix
base: gui-gl-context
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am running on macOS Sierra 10.12.5 Beta (16F43c). Here's the compiler configuration I used when I encountered the error.
|
de7acdb
to
a20cae2
Compare
b9d15b7
to
2bc8a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we don't require the
glext.h
header on Mac, but if that's the case, I am not sure why I get compile error:Maybe we get everything except debug stuff?
I'm not sure that there is KHR_debug support in Mac. Apparently you'd need OpenGL 4.3.
Mac only has OpenGL 4.1.
I decided to throw in the missing
#define
s, to ensure that the code at least compiled.The license for
glext.h
seems pretty permissive, so hopefully this is fine.