Apply suggestions from code review

ViewComponent · Nov 21, 2024 · abd7133 · abd7133
1 parent 74ea9d8
commit abd7133
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -18,7 +18,7 @@ nav_order: 5
 
     *Joel Hawksley*
 
-* Add rails 8 support
+* Add rails 8 support to CI.
 
     *Reegan Viljoen*
 

diff --git a/test/sandbox/config/initializers/assets.rb b/test/sandbox/config/initializers/assets.rb
@@ -1,3 +1,3 @@
 # frozen_string_literal: true
 
-if Rails.version.to_f <= 7.2 then Rails.application.config.assets.precompile += %w[admin.css] end
+Rails.application.config.assets.precompile += %w[admin.css] if Rails.version.to_f <= 7.2
diff --git a/test/sandbox/test/rendering_test.rb b/test/sandbox/test/rendering_test.rb
@@ -338,7 +338,8 @@ def test_renders_component_with_asset_url
 
     if Rails.version.to_f < 8.0
 
-      #  Propshaft doesnt allow setting custom hosts so this only works in Rails < 8
+      #  Propshaft doesn't allow setting custom hosts so this only works in Rails < 8
+      # TODO: Revisit this comment for v4 to see if we need to make any deprecations
       component.config.asset_host = nil
       assert_match(%r{/assets/application-\w+.css}, render_inline(component).text)